GNOME Bugzilla – Bug 594801
Use accessor functions instead direct access
Last modified: 2015-12-17 14:41:31 UTC
http://live.gnome.org/GnomeGoals/UseGseal [mjc@xena gthumb]$ make CFLAGS+="-DGSEAL_ENABLE" > eraseme make[2]: Circular gth-enum-types.h <- gth-enum-types.h dependency dropped. make[4]: Circular gth-enum-types.h <- gth-enum-types.h dependency dropped. eggfileformatchooser.c: In function ‘error_message_with_parent’: eggfileformatchooser.c:591: error: ‘GtkWindow’ has no member named ‘group’ eggfileformatchooser.c:592: error: ‘GtkWindow’ has no member named ‘group’ eggfileformatchooser.c: In function ‘get_toplevel’: eggfileformatchooser.c:605: error: ‘GtkObject’ has no member named ‘flags’ make[4]: *** [gthumb-eggfileformatchooser.o] Error 1 make[3]: *** [all-recursive] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
Hey this is fixed! :-) I just tested it in today's master [ hawran@hobbes :{11:40:06}: ~/code/gthumb ] $ git pull Already up-to-date. [ hawran@hobbes :{11:40:38}: ~/code/gthumb ] $ make CFLAGS+="-DGSEAL_ENABLE" > eraseme make[2]: Dépendance circulaire gth-enum-types.h <- gth-enum-types.h abandonnée. make[4]: Dépendance circulaire gth-enum-types.h <- gth-enum-types.h abandonnée. Close ?
no, it's not fixed yet
Created attachment 156169 [details] [review] Use accessor functions instead direct access. First patch This is a first patch, some accessors still remaining
This is fixed for gtk+ version 2.20, version 2.21 requires other (few) accessors but I don't want gthumb to depend on gtk+ 2.21 just for that.
Hey Paolo, any news about this? Do you plan to port gthumb to GTK+3 ?
Not in this development cycle, my current plan is to release version 2.14 as a Gtk+ 2 application and then port gthumb to Gtk+ 3 for the next major release.
Current versions use gtk3. Marking as obsolete.