GNOME Bugzilla – Bug 594555
Should darken workspaces immediately for app well menu
Last modified: 2009-09-21 22:46:00 UTC
The effect now is that the darkening of windows only happens when you go over a menu item first - so the effect is that everything *but* that window changes, while you want the effect to be that the window for the item you just entered changes and nothing else does. If you immediately darkened everything when popping up the app-well menu, this wouldn't happen...
Created attachment 142751 [details] [review] [AppWell] Enable lightboxing immediately on popup Rather than starting lightboxing only when the mouse enters the menu, start it when an application filter is set. Also delete a stale function in WindowClone from previous work.
Review of attachment 142751 [details] [review]: Definitely better. The 0x44/0xff lightboxing may a still bit too strong (seems to be still effective to me at 0x22/0xff) but we probably should leave further tweaks until we get some feedback from Jon/Jeremy. Patch generally looks good, few small comments. ::: js/ui/overview.js @@ -392,2 +392,3 @@ }, + Stray line here @@ -396,3 +397,3 @@ - * @id: A string application identifier + * @appid: Application identifier string * - * Hide all windows which are not owned by the application + * Enter a mode which shows only the widnows owned by the widnows @@ -399,2 +401,3 @@ + * window with setHighlightWindow(). */ - setWindowApplicationFilter: function (id) { + beginApplicationWindowSelection: function (appid) { It can't be called 'beginApplicationWindowSelection' if you call it with null to leave the selection (should be mentioned in the doc comment). setSelectWindowsApplication() maybe. Member variable appIdFilter should be renamed to match.
This one got committed as part of another patch.