GNOME Bugzilla – Bug 594507
doesn't notice if share goes away
Last modified: 2014-08-25 09:18:30 UTC
I had a dav share mounted (exported via gnome-user-share). When I stopped sharing it on the remote side I expected it to disappear, but it doesn't. I still see 'mclasen's public files on planemask' in network:// even though it doesn't show up in avahi-browse -a anymore, and the mount for that share does not go away either. Of course, clicking on either just times out now...
Created attachment 279929 [details] [review] dav: Force unmount when dns-sd data changes Force unmount the backend when the resolved data changes (most likely when the remote service disappears).
The above patch fixes the problem for an existing mount. It appears that the network:/// behavior has been fixed already; the dav mount disappears as soon as the service is shut down.
Review of attachment 279929 [details] [review]: It makes sense to me, however are all the possible changes problematic? Wouldn't be better to unmount only if e.g. is-resolved is false?
(In reply to comment #3) > Review of attachment 279929 [details] [review]: > > It makes sense to me, however are all the possible changes problematic? > Wouldn't be better to unmount only if e.g. is-resolved is false? From what I can see, the possible changes are: Address Port txt-records (looks like it might contain extra data such as a path or username) is-resolved Handling a change in any of this information while the share is in use could be tricky so I think the safest/easiest thing to do is to just do a clean shutdown.
Comment on attachment 279929 [details] [review] dav: Force unmount when dns-sd data changes I think it so, but just asking :-) (Maybe it would be good to comment this possibility in a code...)
Pushed to master as 367053db51e84c81c21fafd3d7476be8ff2301ce (with a comment). Thanks for the review!