GNOME Bugzilla – Bug 59446
stock ticker in vertical panel spreads panel to ridiculous widths
Last modified: 2003-03-11 18:51:55 UTC
stock-ticker applet wrecks vertical panel appearance by increasing its size dramatically. create vertical panel. panel->applets->add->network->stock ticker panel expands widely. No options on preferences about honouring panel size. expected results: hmm. _ideally_ it should either scroll down, changing itself completely. Or it should scroll horizontally but not expand, even if this means you are going to see one or two letters at a time. Perhaps it should pick a very tiny font on a vertical panel if it did the latter?
I'll try and see if we can nail this one too.
*** Bug 57185 has been marked as a duplicate of this bug. ***
I'm a bit interested in taking this little problem on actually if you dont mind Kjartan? Im quite new to gtk but I have done some programming using it.
Please do..
Im taking it on so I change the status to assigned.
John, FWIW, typically one assigns to oneself and not a list. Not a huge deal, just typical protocol. I assume this is still a problem in CVS, so I'm marking GNOME2.
I'm a little confused. Is the stock ticker actually getting wider when on vertical panels. In the code the size of the applet is hard coded so it shouldn't get any bigger. As to making it fit to panel sizes, it won't happen for GNOME2. Making it scroll vertically would be difficult, I assume, using the GNOME1 framework. Maybe Pango makes it easier to do vertical text, but there will be a bit of work necessary to get it to work with Pango (it will continue to use GdkFont for GNOME2). So basically you shouldn't add the stock ticker to a vertical panel ;)
As I understand it the problem is that you cant resize the applet. On a horizontal panel. This doesnt matter that much but on a vertical one it makes a bigger difference. I've been hacking a bit on the code (v1.4.0.5) to fix this. I have added some functionality to the preference menu that lets you set gtik to scale after the panel or let the user set prefered width. It works quite well but the preference dialog could use some more code. I didnt spend to much attention on it since I figurered that it would probably change a bit in gnome2. I send a patch with the code:
Created attachment 7235 [details] [review] Add options to preferences to set size or set auto-scale to panel
Adding patcch and cc'ing kevin. FWIW, John, it would be really cool if you could patch the gnome2 panel for this too ;)
Going to test this for 1.4.1
You can now change the width of the stock-ticker in HEAD for GNOME2 (which will become the 2.2 release). Removing the GNOME2 keyword
John, the patch doesn't really work that great for 1.4.x. I ended up with a > < this small applet when I started it the first time. And it didn't really appear any smaller when I moved the bottom panel to the right...
My patch is a bit basic in that it doesnt do any real magic. It gives the user two new options: to set the width to the panels width or to let the user specify the width by pixels. I haven't checked how it performs using a configuration from an unpatched applet. To use the fit to panel width is probably a good thing as default. So the patch basicly let the user change the width of the applet, but this isnt anything thats going to happen automaticly.
Fixed in gnome2. Marking as a GNOME1 bug.