After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594439 - Do not use gnome-menus to get list of desktop files
Do not use gnome-menus to get list of desktop files
Status: RESOLVED FIXED
Product: bug-buddy
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bug-buddy Maintainers
Bug-buddy Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-07 22:48 UTC by Vincent Untz
Modified: 2009-09-08 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove gnome-menus dependency (12.98 KB, patch)
2009-09-07 23:13 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2009-09-07 22:48:15 UTC 
There's really no point in using gnome-menus to list all desktop files... bug-buddy should simply list all files in the right directories and look at them.

To get the list of directories, use g_get_system_data_dirs() and g_get_system_config_dirs(). I'm not even sure it's worth looking at g_get_user_data_dir() and g_get_user_config_dir()...
Comment 1 Vincent Untz 2009-09-07 23:13:09 UTC 
Created attachment 142658 [details] [review]
Remove gnome-menus dependency

It was only needed to find all the .desktop files, but we can do this
ourselves -- it will be cheaper (no need to parse desktop file twice)
and simpler (the code is trivial).
Comment 2 Vincent Untz 2009-09-07 23:13:54 UTC 
Note that I didn't test the patch -- I'm actually unsure what I should do to test it.
Comment 3 Cosimo Cecchi 2009-09-08 10:35:12 UTC 
Thanks for the patch, I pushed it to master.