GNOME Bugzilla – Bug 594435
Topics in bookmark properties not displayed properly
Last modified: 2009-09-08 08:34:44 UTC
Hi, For any bookmark that has topics, those are not displayed correctly in the bookmark properties. If a bookmark has the "foobar" topic, it will be displayed as "fooba, r", if it as "foo" and "bar", it will be displayed as "fo, bar, o". I.e. the ", " is introduced before the last character for the first topic. The attached patch fixes the issue for me. Tested with ephy 2.27.91 and gtk+ 2.17.9.
Created attachment 142655 [details] [review] Display bookmark topics properly
(In reply to comment #1) > Created an attachment (id=142655) [details] > Display bookmark topics properly Looks good! While you are at it you could make it not add the comma for the last topic too.
Created attachment 142677 [details] [review] also, remove the trailing comma Sure. This one adds a comma before the topic, rather than after it, but doesn't do it for the first topic (the pos > 0 check). I've tested it with a couple of bookmarks (1 and 3 topics) and works fine. The other option would be to keep it as is, and after the loop, remove the trailing comma if any, but this looks cleaner to me.
(In reply to comment #3) > Created an attachment (id=142677) [details] > also, remove the trailing comma > > Sure. This one adds a comma before the topic, rather than after it, but doesn't > do it for the first topic (the pos > 0 check). I've tested it with a couple of > bookmarks (1 and 3 topics) and works fine. > > The other option would be to keep it as is, and after the loop, remove the > trailing comma if any, but this looks cleaner to me. Looks good, please commit.
I can't, can you do it for me?
Committed, will be in 2.28.0.