After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594321 - Videomeasure plugin
Videomeasure plugin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-06 16:25 UTC by LRN
Modified: 2009-09-10 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against -bad git (78.23 KB, patch)
2009-09-06 16:25 UTC, LRN
none Details | Review
Patch against 584b5b6106c393b6a76542149fbed295dc7fedd9 (80.62 KB, patch)
2009-09-09 14:26 UTC, LRN
none Details | Review
Patch against 584b5b6106c393b6a76542149fbed295dc7fedd9, removed liboil stuff (80.84 KB, patch)
2009-09-09 15:15 UTC, LRN
committed Details | Review

Description LRN 2009-09-06 16:25:54 UTC
Created attachment 142601 [details] [review]
Patch against -bad git

Plugin for getting various metrics from video streams. At the moment it
consists of two elements - SSIM index calculator and video measure collector.
PSNR and others may be implemented in future. I'm also considering extracting
common functionality (such as N-to-N-1 request pad construction, pad linking,
caps restriction, buffer collection, etc) into a base class, but i think i'll
have to implement other metrics first, so that i'll be able see what exactly IS
common between two different metric-calculating elements.
Comment 1 Sebastian Dröge (slomo) 2009-09-08 13:43:03 UTC
Just a short note, I didn't really review the patch yet:
- Write a meaningful commit message and include something like "Fixes bug #12345"
- Include the instance/class structs in the header files, otherwise gtk-doc will be unhappy

Is this ready to be reviewed otherwise?
Comment 2 LRN 2009-09-09 14:26:19 UTC
Created attachment 142792 [details] [review]
Patch against 584b5b6106c393b6a76542149fbed295dc7fedd9
Comment 3 Tim-Philipp Müller 2009-09-09 14:54:30 UTC
Could you also put your proper name into the copyright notice please?
Comment 4 LRN 2009-09-09 15:15:55 UTC
Created attachment 142795 [details] [review]
Patch against 584b5b6106c393b6a76542149fbed295dc7fedd9, removed liboil stuff
Comment 5 Sebastian Dröge (slomo) 2009-09-10 10:08:28 UTC
commit 2a7ee0716fe13af5ab444193e2017be1931db342
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Sep 10 12:02:21 2009 +0200

    videomeasure: Fix format strings and include correct i18n header

commit bdbd944c5270e6037d79b6ebf43b5db96a107b97
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Sep 10 11:58:02 2009 +0200

    videomeasure: Fix indention, line endings and use LRN's real name

commit e9297ba3eb7af24a81051dfc57f0ff5cbd15735e
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Sep 9 19:14:27 2009 +0400

    videomeasure: Initial version of videomeasure plugin
    
    This plugin contains elements for calculating metrics of video streams, inte
    At the moment only SSIM metric is implemented (why would you need anything e
    Also contains a helper videomeasure_collector element that collects measurem
    Other metrics may be implemented in the future along with a base class for a
    
    Fixes bug #594321.