After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594315 - Get rid of shave with AM_SILENT_RULES automake option
Get rid of shave with AM_SILENT_RULES automake option
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other All
: Low enhancement
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-06 15:18 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-03-22 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Get rid of shave with AM_SILENT_RULES (1.83 KB, patch)
2009-09-06 15:18 UTC, Javier Jardón (IRC: jjardon)
rejected Details | Review
Use AM_SILENT_RULES and shave if automake 1.11 is not available (1.45 KB, patch)
2009-09-07 19:10 UTC, Javier Jardón (IRC: jjardon)
rejected Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-06 15:18:00 UTC
Automake 1.11 supports Linux-kernel like silent build rules with easy ways to
switch to the more verbose output either at configure time:

  ./configure --disable-silent-rules

or at make time:

  make V=1

IMHO would be better to "require newer version of existing tool" than to drag
in
a new special-purpose widget.

The attached patch enables silent build rules by default.
Comment 1 Javier Jardón (IRC: jjardon) 2009-09-06 15:18:50 UTC
Created attachment 142598 [details] [review]
Get rid of shave with AM_SILENT_RULES
Comment 2 Sebastian Dröge (slomo) 2009-09-07 06:13:36 UTC
That should definitely be done at some point but automake 1.11 is really too new... maybe in 6 months. But that's just my opinion.

(and wasn't the automake AM_SILENT_RULES stuff based on shave?)
Comment 3 Javier Jardón (IRC: jjardon) 2009-09-07 19:10:57 UTC
Created attachment 142636 [details] [review]
Use AM_SILENT_RULES and shave if automake 1.11 is not available

Here an alternative patch.
In this patch shave is used if automake1.11 is not present, and AM_SILENT_RULES if you have automake >= 1.11 installed
Comment 4 Sebastian Dröge (slomo) 2009-09-08 12:42:21 UTC
Is there any reason why you want to use AM_SILENT_RULES over shave? IMHO it makes sense to replace shave by AM_SILENT_RULES in a few months when automake 1.11 is old but conditionally using AM_SILENT_RULES if an older automake is found brings no advantages IMHO.

Let's keep the original patch in Bugzilla and wait... :)
Comment 5 Sebastian Dröge (slomo) 2010-02-26 14:54:09 UTC
Comment on attachment 142598 [details] [review]
Get rid of shave with AM_SILENT_RULES 

If no AM_SILENT_RULES is available you have to AC_SUBST and set AM_DEFAULT_VERBOSITY=1. Otherwise things break in some cases.
Comment 6 Sebastian Dröge (slomo) 2010-02-26 14:54:16 UTC
I have patches for all modules locally, gst-python and gnonlin are already fixed in GIT.
Comment 7 Tim-Philipp Müller 2010-03-22 13:55:12 UTC
This is fixed in all modules now as far as I know, closing.