After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594279 - dshowsrcwrapper: use tchar macro for string literals
dshowsrcwrapper: use tchar macro for string literals
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-05 23:46 UTC by Håvard Graff (hgr)
Modified: 2009-09-08 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.93 KB, patch)
2009-09-05 23:46 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2009-09-05 23:46:46 UTC 
Created attachment 142573 [details] [review]
patch

To avoid the issues with MultiByte vs UniCode
Comment 1 Julien Isorce 2009-09-07 10:44:23 UTC 
Hi, this requires to have "Windows SDK for Windows Server 2008" according to:
http://blogs.msdn.com/mikewasson/archive/2008/03/07/what-is-strmbasedu-lib-and-where-did-it-go.aspx

Well, ok why not.

Last thing, why you didn't change the other L ?  (ex: L"capture" etc...)

Can you describe your build environment ? (os, sdk etc ...)
Comment 2 Håvard Graff (hgr) 2009-09-07 12:14:48 UTC 
Oh, I must have missed that one. Ment to change them all.

We use Microsoft Visual Studio 2008 on Windows.
Comment 3 Julien Isorce 2009-09-07 14:49:11 UTC 
I did a fresh frozen build then I only did:

--- a/sys/dshowsrcwrapper/gstdshowfakesink.cpp
+++ b/sys/dshowsrcwrapper/gstdshowfakesink.cpp
@@ -25,7 +25,7 @@ CDshowFakeSink::CDshowFakeSink ():
m_hres (S_OK),
m_callback (NULL),
m_data (NULL),
-CBaseRenderer (CLSID_DshowFakeSink, "DshowFakeSink", NULL, &m_hres)
+CBaseRenderer (CLSID_DshowFakeSink, _T("DshowFakeSink"), NULL, &m_hres)

And then I's ok for both unicode and MBCS.

See commit:

--- a/sys/dshowsrcwrapper/gstdshowfakesink.cpp
+++ b/sys/dshowsrcwrapper/gstdshowfakesink.cpp
@@ -25,7 +25,7 @@ CDshowFakeSink::CDshowFakeSink ():
m_hres (S_OK),
m_callback (NULL),
m_data (NULL),
-CBaseRenderer (CLSID_DshowFakeSink, "DshowFakeSink", NULL, &m_hres)
+CBaseRenderer (CLSID_DshowFakeSink, _T("DshowFakeSink"), NULL, &m_hres)

So if you still think other L".." must be replaced by _T then please make a new patch. Thx
Comment 4 Sebastian Dröge (slomo) 2009-09-08 13:59:52 UTC 
commit 503091ae0ef2c4edc68f438b2bd1f30afbe5cf43
Author: Julien Isorce <julien.isorce@gmail.com>
Date:   Mon Sep 7 16:44:52 2009 +0200

    dshowsrcwrapper: add support both Unicode and MBCS