After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594256 - improved slave-skew resynch mechanism
improved slave-skew resynch mechanism
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal critical
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-05 18:59 UTC by Håvard Graff (hgr)
Modified: 2009-09-08 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.74 KB, patch)
2009-09-05 18:59 UTC, Håvard Graff (hgr) 		none Details | Review
patch (6.21 KB, patch)
2009-09-05 19:00 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2009-09-05 18:59:48 UTC 
Created attachment 142552 [details] [review]
patch

The old one did the mistake of not actually advancing the ringbuffer, it just
adjusted the segbase, introducing the whole lenght of the ringbuffer as an
extra delay in the pipeline.

Also make sure that the resync can never go back in time, producing the same
timestamps that has already been produced, as this can cause severe problems
for sinks and other synching mechanisms.
Comment 1 Håvard Graff (hgr) 2009-09-05 19:00:10 UTC 
Created attachment 142553 [details] [review]
patch
Comment 2 Håvard Graff (hgr) 2009-09-05 19:01:12 UTC 
Sorry about the two patches.
Comment 3 Wim Taymans 2009-09-08 11:00:41 UTC 
commit 058776bcf1ab218b509d19685a0b528d71c65f98
Author: Håvard Graff <havard.graff@tandberg.com>
Date:   Tue Sep 8 12:59:20 2009 +0200

    baseaudiosrc: improve slave skew resync
    
    The old one did the mistake of not actually advancing the ringbuffer, it just
    adjusted the segbase, introducing the whole lenght of the ringbuffer as an
    extra delay in the pipeline.
    
    Also make sure that the resync can never go back in time, producing the same
    timestamps that has already been produced, as this can cause severe problems
    for sinks and other synching mechanisms.
    
    Fixes #594256