After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594251 - Avoid throwing out reordered packets with the same timestamp
Avoid throwing out reordered packets with the same timestamp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-05 18:32 UTC by Håvard Graff (hgr)
Modified: 2009-09-08 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.58 KB, patch)
2009-09-05 18:32 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2009-09-05 18:32:31 UTC
Created attachment 142549 [details] [review]
patch

When receiving an I-frame, and the far end does not use packet-smoothing, you
can have several packets arriving with the same timestamp. If there is jitter
in the network, these packets might be reordered. With the current
implementation, these packet would then be marked as lost, and dropped.

Also, the patch switches the warning-level, so that a reordering does not get a
warning, only an actual produced lost-packet.
Comment 1 Wim Taymans 2009-09-08 11:43:07 UTC
commit 40549278c31c601164ab29c28afbb463db907942
Author: Håvard Graff <havard.graff@tandberg.com>
Date:   Tue Sep 8 13:39:31 2009 +0200

    jitterbuffer: avoid throwing reordered buffers with same timestamps
    
    When we receive a reordered packet with the same timestamp as the previous one
    (which can happen for fragmented packets) don't consider the packet as lost but
    instead wait for the reordered packet to arrive.
    
    Switch the warning-level, so that a reordering does not get a warning, only
    an actual produced lost-packet.
    
    Fixes #594251