After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594030 - [mpegtsdemux] Support for AC3/EAC3 not 100% correct
[mpegtsdemux] Support for AC3/EAC3 not 100% correct
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-03 13:30 UTC by Sebastian Dröge (slomo)
Modified: 2010-05-22 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2009-09-03 13:30:25 UTC 
Hi,
as discussed on IRC the AC3/EAC3 support in mpegtsdemux is not 100% correct. There's a Fluendo changeset that seems to implement it properly though: https://core.fluendo.com/gstreamer/trac/changeset?new=trunk%2Fgst-fluendo-mpegdemux%2Fsrc%401677&old=trunk%2Fgst-fluendo-mpegdemux%2Fsrc%401676

This should be tested and merged before any new gst-plugins-bad release.
Comment 1 Sebastian Dröge (slomo) 2009-09-03 13:47:01 UTC 
commit b9486bf032991e83a6a878b422d7f2cce4ad7909
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Sep 3 15:45:06 2009 +0200

    mpegtsdemux: If stream type is AC3 and no EAC3 descriptor is found assume AC

commit da643bf921397f19f0ed5c84b87366c890104494
Author: Josep Torra <josep@fluendo.com>
Date:   Thu Sep 3 15:40:14 2009 +0200

    mpegtsdemux: Implement EAC3 handling according some ATSC specs.
    
    Fixes bug #594030.
Comment 2 Philip Jägenstedt 2010-05-22 14:54:18 UTC 
Sebastian, would you happen to know what exactly those specs say? Making another attempt at fixing https://bugzilla.gnome.org/show_bug.cgi?id=605980 I find that the code responsible for detecting my AC3 as E-AC3 was added by you and Josep Torra around c67dc212bfc4f.