After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593651 - buffer-size property of ffenc_* is a cop-out
buffer-size property of ffenc_* is a cop-out
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-31 10:42 UTC by Benjamin Otte (Company)
Modified: 2009-10-01 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Benjamin Otte (Company) 2009-08-31 10:42:00 UTC 
The buffer-size property of ffenc needs to go. There's no way for a user to know the proper buffer size.

From reading the code it looks like it was introduced because noone had any clue how to properly size the encoding buffers, so instead of fixing it, areasonably large number was taken and because it sometimes failed, it was made a property, so one could override it.

FWIW: ffmpeg itself uses 6 * width * height + 200 - doesn't sound a lot better.
Comment 1 Sebastian Dröge (slomo) 2009-10-01 14:47:30 UTC 
commit d9f6febe7015bbbbce7ddc82503f43751f7eb168
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Oct 1 16:44:22 2009 +0200

    ffenc: Make sure to always provide large enough buffers
    
    For audio always add the minimum ffmpeg buffer size, for video
    use the same weird buffer size as they use in ffmpeg.c:
    width*height*6 + 200
    
    Also make setting of the buffer-size property a no-op.
    
    Fixes bug #593651.
Comment 2 Sebastian Dröge (slomo) 2009-10-01 15:06:59 UTC 
I'll push it after 0.10.9 release.