GNOME Bugzilla – Bug 593608
unnamed unions is not built-able with sun cc
Last modified: 2009-08-31 17:32:50 UTC
I'm building libgoffice git-master code with sun cc. But fails with following error: argument : pointer to const unsigned char "go-style.c", line 1787: improper member use: outline "go-style.c", line 1789: improper member use: line "go-style.c", line 1870: improper member use: outline "go-style.c", line 1870: improper member use: outline "go-style.c", line 1871: improper member use: outline "go-style.c", line 1871: improper member use: outline "go-style.c", line 1872: improper member use: line "go-style.c", line 1872: improper member use: line "go-style.c", line 1894: improper member use: outline "go-style.c", line 1895: improper member use: outline "go-style.c", line 1904: improper member use: line "go-style.c", line 1905: improper member use: line "go-style.c", line 1927: improper member use: outline "go-style.c", line 1928: improper member use: outline "go-style.c", line 1929: improper member use: line "go-style.c", line 1930: improper member use: line cc: acomp failed for go-style.c
I thought that anonymous unions were standard. Seems I was wrong, sorry. Will fix as soon as possible.
Created attachment 142100 [details] [review] proposed patch Seems this does not break anything else.
Jean, your patch fixes just a piece. I'm still working on it. Will offer here later. (In reply to comment #2) > Created an attachment (id=142100) [details] > proposed patch > > Seems this does not break anything else.
Created attachment 142102 [details] [review] remove unamed union Sorry, Jean, your patch works fine on Solaris. I just rework this patch to remove the already committed part for go-styled-object.c. The line "#define outline line" seems ugly. Need we convert usage ->outline to ->line?
Of course, it is just a quick fix. If it was easy to drop all the outline stuff, it would have been done since several years. We need to communicate that outline will be deprecated in future versions so that every project using GOStyle updates its code accordingly.
(In reply to comment #5) > Of course, it is just a quick fix. If it was easy to drop all the outline > stuff, it would have been done since several years. We need to communicate that > outline will be deprecated in future versions so that every project using > GOStyle updates its code accordingly. So need I work out the patch?
I'll do when time permits.
Just deprectaed GOStyle::outline. Fixed.