GNOME Bugzilla – Bug 593503
ShellButtonBox: Use default handlers, not self-connections
Last modified: 2009-08-29 19:33:59 UTC
There's seldom a good justification for connecting to signals on yourself rather than using the default handler slots in the class. But in particular using the default handler slots means that an application can connect to ::button-press-event and get in before the default handling, to implement a button that does something on press.
Created attachment 141992 [details] [review] ShellButtonBox: Use default handlers, not self-connections
Comment on attachment 141992 [details] [review] ShellButtonBox: Use default handlers, not self-connections Yep; sorry, was translating from a half-done JS version I had written before deciding properties with notification were the way to go.
Pushed