After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593502 - Add an active property to ShellButtonBox
Add an active property to ShellButtonBox
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 593471
 
 
Reported: 2009-08-29 17:39 UTC by Owen Taylor
Modified: 2009-08-31 00:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add an active property to ShellButtonBox (3.44 KB, patch)
2009-08-29 17:39 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2009-08-29 17:39:09 UTC
Add an 'active' property to ShellButtonBox. This allows ShellButtonBox
to be used as a "toggle button". It's up the application to connect
it to the ::activate signal; there's no default handling of this.

(It's seldom that the only time you want to toggle a toggle button
through the user interface, so you need some connection to the backend
data store in any case. Removing the default handling all-together
prevents weird interactions.)

When we have built-in styling for ShellButtonBox the 'active' state
would be one of the elements that would be affect the styling.
Comment 1 Owen Taylor 2009-08-29 17:39:12 UTC
Created attachment 141991 [details] [review]
Add an active property to ShellButtonBox
Comment 2 Colin Walters 2009-08-29 17:41:40 UTC
Comment on attachment 141991 [details] [review]
Add an active property to ShellButtonBox

Yay, thank you.
Comment 3 Owen Taylor 2009-08-29 19:33:31 UTC
Pushed
Comment 4 Owen Taylor 2009-08-31 00:46:02 UTC
Comment on attachment 141991 [details] [review]
Add an active property to ShellButtonBox

Attachment 141991 [details] pushed as 45c600c - Add an active property to ShellButtonBox