After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593460 - Broken win32-specific systemclock code
Broken win32-specific systemclock code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal blocker
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-29 00:49 UTC by LRN
Modified: 2009-08-29 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Casts clock to systemclock on Win32, includes gstutils.h on Win32. (122.27 KB, patch)
2009-08-29 00:49 UTC, LRN 		none Details | Review

Description LRN 2009-08-29 00:49:04 UTC 
Created attachment 141974 [details] [review]
Casts clock to systemclock on Win32, includes gstutils.h on Win32.

1) Does not cast clock to systemclock before accessing systemclock-specific
private fields
2) Uses scale function from utils without including gstutils.h

Patch attached, fixes both.
Comment 1 Tim-Philipp Müller 2009-08-29 10:34:33 UTC 
Fixed (I ignored all the unrelated other stuff):

 commit 4ad052fed70b04029166b2f200d7a168b1654fd1
 Author: Руслан Ижбулатов <lrn1986@gmail.com>
 Date:   Sat Aug 29 04:44:51 2009 +0400

    systemclock: fix compilation of win32 code
    
    Fixes #593460.

Could you *please* submit patches with your author name set properly. You're just causing us more work ..