After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593348 - faac encoder produces first buffer with wrong duration
faac encoder produces first buffer with wrong duration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.12
Other All
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-28 01:29 UTC by Roland Krikava
Modified: 2009-09-01 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes bug (16.71 KB, patch)
2009-08-28 01:30 UTC, Roland Krikava 		needs-work Details | Review
Rewrite data caching and timestamp handling (14.66 KB, patch)
2009-08-29 20:04 UTC, Mark Nauwelaerts 		committed Details | Review

Description Roland Krikava 2009-08-28 01:29:20 UTC 
If running the following pipeline, you'll notice that the first output buffer has a duration quite a bit larger than those that follow:

GST_DEBUG=faac:5 gst-launch alsasrc ! faac ! fakesink

The buffer duration of output buffers should be the same as those fed to the encoder.  The attached patch fixes the bug.
Comment 1 Roland Krikava 2009-08-28 01:30:44 UTC 
Created attachment 141907 [details] [review]
Fixes bug
Comment 2 David Schleef 2009-08-28 01:38:05 UTC 
Comment on attachment 141907 [details] [review]
Fixes bug

Please fix the patch to not have whitespace changes.
Comment 3 Mark Nauwelaerts 2009-08-29 20:04:17 UTC 
Created attachment 141998 [details] [review]
Rewrite data caching and timestamp handling

Rather than some tinkering with timestamps, etc, attached patch removes all the buffer and timestamp voodoo.  In stead, use an adapter & co.

In particular, it should take care of this buffer duration issue.
Comment 4 Sebastian Dröge (slomo) 2009-08-30 19:48:26 UTC 
Less voodoo is always a good idea.. looks good IMHO :)
Comment 5 Mark Nauwelaerts 2009-09-01 09:01:59 UTC 
commit f81b1e7a4af1ff626a6eddedcae98c2f8b48c08d
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Sun Aug 30 23:00:35 2009 +0200

    faac: rewrite data caching and timestamp handling

    Also fixes #593348.