GNOME Bugzilla – Bug 593257
Translatable strings not well constructed
Last modified: 2009-08-28 12:09:05 UTC
There are three constructed translatable strings that can be difficult to translate in some languages. The code is this: /* translators: this is followed by the "while ..." strings some lines * down this file. */ str = g_string_new (_("There has been an error ")); if (page_num == PAGE_IMPORT) /* translators: this follows the "There has been an error " string */ str = g_string_append (str, _("while importing the accounts.")); else if (page_num >= PAGE_ENTER_CREATE && priv->first_resp == RESPONSE_ENTER_ACCOUNT) /* translators: this follows the "There has been an error " string */ str = g_string_append (str, _("while parsing the account details.")); else if (page_num >= PAGE_ENTER_CREATE && priv->first_resp == RESPONSE_CREATE_ACCOUNT) /* translators: this follows the "There has been an error " string */ str = g_string_append (str, _("while creating the account.")); I already asked for a string freeze break request to address this problem.
Created attachment 141827 [details] [review] Do not construct sentence for an assistant error string (GNOME bug 593257)
Created attachment 141828 [details] [review] Do not construct a sentence for an assistant error string (GNOME bug 593257)
Comment on attachment 141828 [details] [review] Do not construct a sentence for an assistant error string (GNOME bug 593257) > char *message; I think this should be "const char *" now, otherwise it looks good. As for the thread here [1] it seems that we still need another gnome-i18n approval before committing, right? [1] http://mail.gnome.org/archives/gnome-i18n/2009-August/msg00267.html
Created attachment 141829 [details] [review] Do not construct a sentence for an assistant error string (GNOME bug 593257)
Comment on attachment 141829 [details] [review] Do not construct a sentence for an assistant error string (GNOME bug 593257) Looks good to me. Please commit as soon as the string exception is accepted.
Pushed. commit a72c1e74b5865aed5a132dc568c01038f4050281 Author: Frédéric Péters <fpeters@0d.be> Date: Thu Aug 27 10:27:35 2009 +0200 Do not construct a sentence for an assistant error string (GNOME bug 593257)