After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593257 - Translatable strings not well constructed
Translatable strings not well constructed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.27.x
Other Linux
: Normal trivial
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-27 07:54 UTC by Milo Casagrande
Modified: 2009-08-28 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not construct sentence for an assistant error string (GNOME bug 593257) (2.42 KB, patch)
2009-08-27 08:07 UTC, Frederic Peters
none Details | Review
Do not construct a sentence for an assistant error string (GNOME bug 593257) (2.47 KB, patch)
2009-08-27 08:13 UTC, Frederic Peters
reviewed Details | Review
Do not construct a sentence for an assistant error string (GNOME bug 593257) (2.50 KB, patch)
2009-08-27 08:27 UTC, Frederic Peters
accepted-commit_now Details | Review

Description Milo Casagrande 2009-08-27 07:54:29 UTC
There are three constructed translatable strings that can be difficult to translate in some languages. The code is this:

 /* translators: this is followed by the "while ..." strings some lines
  * down this file.
  */
 str = g_string_new (_("There has been an error "));

 if (page_num == PAGE_IMPORT)
   /* translators: this follows the "There has been an error " string */
   str = g_string_append (str, _("while importing the accounts."));
 else if (page_num >= PAGE_ENTER_CREATE &&
     priv->first_resp == RESPONSE_ENTER_ACCOUNT)
   /* translators: this follows the "There has been an error " string */
   str = g_string_append (str, _("while parsing the account details."));
 else if (page_num >= PAGE_ENTER_CREATE &&
     priv->first_resp == RESPONSE_CREATE_ACCOUNT)
   /* translators: this follows the "There has been an error " string */
   str = g_string_append (str, _("while creating the account."));

I already asked for a string freeze break request to address this problem.
Comment 1 Frederic Peters 2009-08-27 08:07:31 UTC
Created attachment 141827 [details] [review]
Do not construct sentence for an assistant error string (GNOME bug 593257)
Comment 2 Frederic Peters 2009-08-27 08:13:46 UTC
Created attachment 141828 [details] [review]
Do not construct a sentence for an assistant error string (GNOME bug 593257)
Comment 3 Cosimo Cecchi 2009-08-27 08:25:41 UTC
Comment on attachment 141828 [details] [review]
Do not construct a sentence for an assistant error string (GNOME bug 593257)


>   char *message;

I think this should be "const char *" now, otherwise it looks good.

As for the thread here [1] it seems that we still need another gnome-i18n approval before committing, right?

[1] http://mail.gnome.org/archives/gnome-i18n/2009-August/msg00267.html
Comment 4 Frederic Peters 2009-08-27 08:27:57 UTC
Created attachment 141829 [details] [review]
Do not construct a sentence for an assistant error string (GNOME bug 593257)
Comment 5 Guillaume Desmottes 2009-08-27 13:46:35 UTC
Comment on attachment 141829 [details] [review]
Do not construct a sentence for an assistant error string (GNOME bug 593257)

Looks good to me. Please commit as soon as the string exception is accepted.
Comment 6 Frederic Peters 2009-08-28 12:09:05 UTC
Pushed.

commit a72c1e74b5865aed5a132dc568c01038f4050281
Author: Frédéric Péters <fpeters@0d.be>
Date:   Thu Aug 27 10:27:35 2009 +0200

    Do not construct a sentence for an assistant error string (GNOME bug 593257)