After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593212 - non-pixel size used for search entry
non-pixel size used for search entry
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-26 19:22 UTC by Owen Taylor
Modified: 2009-08-28 20:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Switch Find entry text size to px (1.17 KB, patch)
2009-08-28 20:23 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2009-08-26 19:22:22 UTC 
Almost everywhere we specify our font sizes in terms of pixels - good, bad, hard to say. Should move to CSS stylesheets anyways. But we need to be consistent.

The search entry has:

        let textProperties = { font_name: "Sans 12" };

Depending on the "DPI" (points/pixel factor) of the user's environment, this may be way out of scale with the rest of the text and potentially quite large.
Comment 1 Owen Taylor 2009-08-28 20:23:51 UTC 
Created attachment 141959 [details] [review]
Switch Find entry text size to px

All our font sizes were in px, other than the size for the text in
the search entry. Switch that from 12 to 16px (which is the same size
at the standard 96dpi), it doesn't become out of scale if the DPI
is different. (Using fixed px sizes isn't probably what we want to
do in the long term; moving to style sheets will be a good place to
fix that. But better to be consistent.)
Comment 2 Owen Taylor 2009-08-28 20:24:24 UTC 
Pushed as too trivial to need review.