GNOME Bugzilla – Bug 593207
URL contains the rest of the line
Last modified: 2009-08-28 17:03:23 UTC
When chatting with a friend, send the following line: > Hey theck this http://www.gnome.org cool site! will result in a clickable url (in Adium themes) of > Hey theck this <a href="http://www.gnome.org cool site!">http://www.gnome.org</a> cool site! This is a bug introduced by my fix to Bug #586401.
Created attachment 141782 [details] [review] Fix on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls libempathy-gtk/empathy-theme-adium.c | 2 +- libempathy-gtk/empathy-ui-utils.c | 22 ++++++++++++++++++---- libempathy-gtk/empathy-ui-utils.h | 2 ++ 3 files changed, 21 insertions(+), 5 deletions(-)
I noticed this bug as well.
The doc of empathy_make_absolute_url_len is in the wrong place.
Created attachment 141892 [details] [review] Fix with fixed comments on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls libempathy-gtk/empathy-theme-adium.c | 2 +- libempathy-gtk/empathy-ui-utils.c | 38 +++++++++++++++++++++++---------- libempathy-gtk/empathy-ui-utils.h | 2 + 3 files changed, 29 insertions(+), 13 deletions(-)
Comment on attachment 141892 [details] [review] Fix with fixed comments on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls > g_return_val_if_fail (url != NULL, NULL); > >+ > if (g_str_has_prefix (url, "ghelp:") || Could you please remove this whitespace when committing? Other than this, the patch looks good to me.
Merged, thanks.