GNOME Bugzilla – Bug 593203
orca preferences does not fit in 1024x600 screen resolution
Last modified: 2010-08-01 23:09:27 UTC
I'm currently testing in Jaunty beta candidate on an Eee900. In orca, when I click on preferences the window is too tall for the 1024x600 screen. The preferences windows cannot be resized, or maximized, and the buttons at the bottom are not visible. The version currently installed is: gnome-orca 2.26.0-0ubuntu1 https://bugs.launchpad.net/ubuntu/+source/gnome-orca/+bug/348716
Hi Arky: 2.26.x is no longer under development or maintenance. Can you please try again with 2.27.x? We did some work to reduce the height to fix on a 1024x768 display, but I'm not sure how well it will fit on a screen 600 pixels high. Note also that you can move a window around by pressing Alt+F7 and then using the arrow keys. Will
Created attachment 151110 [details] [review] work in progress; not fit for human consumption. I suck at dialog feng shui. This is not ready to go. It's ugly. It might break things. Should you view it, evil spirits will invade your home and/or you'll be turned to stone depending on your personal mythology. It is only here so that Will can take a look and advise. :-) Will: 1. Both the magnification and the speech pages were too tall. 2. Something is causing the window manager to request a height of 612 pixels. I dunno what yet. I tried all the usual suspects (including flat-out specifying the height). No luck. I can resize it down to 545 pixels in height now. I'll look more later. 3. I didn't indent the progress bar items. Well, I did, but the result looked worse. Also we don't indent anything else under the same scenario. Please let me know how you think I should proceed. Thanks! Oh and never mind the evil spirits and stone bit, Will. Really. You'll, uh, be fine. Yeah.... Just fine.... ;-)
Sorry for the spam. I forgot that braille was pretty tall too so I moved things around there as well. The disclaimers in the previous comment apply here.
Wow! The dialog fits on my Toshiba NB205 now, though that silly 612 height request requires me to resize it down to fit. If I just do Alt+space to bring up the window manager menu then hit 'x' for maximize, it ends up resizing nicely to fix the screen. Strange. In any case, I didn't turn into stone. :-) Anyhow...so, going tab by tab. Some of these comments apply to things already present, but others apply to the new stuff. I'll try to make the distinction... General: -------- PRE-EXISTING CONDITION: The Keyboard Layout section just looks weird at the top. I wonder if it might look better beneath the checkboxes? Speech: ------- Looks decent. For the "Progress Bars" section, I wonder if we could eliminate some text since the title "Progress Bars" title lets the user infer what the controls are for. So... "Speak updates", "Update interval (secs):", "Restrict updates to:" I also wonder if moving the "Break speech into chunks between pauses" checkbox might look better below "Speak child position". That is, the spacing looks a little cramped at the bottom of the tab right now, and maybe moving the checkbox would open up a little vertical space on the left hand side. I dunno. I don't have a good eye for this. Braille: -------- There's a lot of space on the new braille page. I don't have any great ideas. Maybe something like: [ ] Enable braille support Verbosity [ ] Enable braille monitor ( ) Brief [ ] Enable contracted braille ( ) Verbose Contraction table: [ ] [ ] Abbreviated role names [ ] Disable end of line symbol Selection Indicator: Hyperlink Indicator: ( ) None ( ) None ( ) Dot 7 ( ) Dot 7 ( ) Dot 8 ( ) Dot 8 ( ) Dots 7 and 8 ( ) Dots 7 and 8 Key Echo: --------- Looks fine. Magnifier: ---------- Looks nice, though it might be nice to align the Tracking and Alignment Settings section up with the Zoomer Settings section (and vice versa). Right now, the Tracking and Alignment Settings section is a line lower than the Zoomer Settings section. PRE-EXISTING CONDITION: Also...maybe we could get rid of the word "settings" everywhere. So "Zoomer", "Tracking and Alignment", "Color", "Border", "Cursor", "Cross-hair", "Advanced..." Key Bindings, Pronunciation, Text Attributes: --------------------------------------------- These all look fine. Many thanks Joanie!
Created attachment 151142 [details] [review] Less suckage, still not done, might give you 7 years bad luck. (In reply to comment #4) > Wow! The dialog fits on my Toshiba NB205 now, though that silly 612 height > request requires me to resize it down to fit. And it still will. Haven't dug into that yet. > General: > -------- > > PRE-EXISTING CONDITION: The Keyboard Layout section just looks weird at the > top. I wonder if it might look better beneath the checkboxes? Dunno. But done in this patch so you can see for yourself. > Speech: > ------- > > Looks decent. For the "Progress Bars" section, I wonder if we could eliminate > some text since the title "Progress Bars" title lets the user infer what the > controls are for. So... "Speak updates", "Update interval (secs):", "Restrict > updates to:" Good idea! I took it one step further and moved the 'update' bit into the label as well and changed some of the language ('enabled' and 'frequency (secs)'. In addition, I removed the word 'Speech' from 'Table Row Speech' because we're on the 'Speech' page, so what else would we do to the silly Table Row/Cell? :-) In that same spirit, I removed the word 'current' from 'Speak current cell' and 'Speak current row'. This resulted in my being able to get the progress bar vbox to the right of the enabled checkbox. I think this helps as well. (There will be some translator notes that need redoing. I'll wait until we've decided upon the language.) > I also wonder if moving the "Break speech into chunks between pauses" checkbox > might look better below "Speak child position". That is, the spacing looks a > little cramped at the bottom of the tab right now, and maybe moving the > checkbox would open up a little vertical space on the left hand side. I dunno. > I don't have a good eye for this. Me neither. I redid the checkboxes in two columns. I think it helps with the lopsidedness some. Lemme know what you think. > Braille: > -------- > > There's a lot of space on the new braille page. I don't have any great ideas. > Maybe something like: > > [ ] Enable braille support Verbosity > [ ] Enable braille monitor ( ) Brief > [ ] Enable contracted braille ( ) Verbose > Contraction table: [ ] > [ ] Abbreviated role names > [ ] Disable end of line symbol > > Selection Indicator: Hyperlink Indicator: > ( ) None ( ) None > ( ) Dot 7 ( ) Dot 7 > ( ) Dot 8 ( ) Dot 8 > ( ) Dots 7 and 8 ( ) Dots 7 and 8 Looks better as ASCII than in widgets. But what you propose looks far better than what I had. Done. > Magnifier: > ---------- > > Looks nice, though it might be nice to align the Tracking and Alignment > Settings section up with the Zoomer Settings section (and vice versa). Heh. I didn't notice that. Sorry. Visual-spatial perception crap.... It has since occurred to me that I could use another window as a straight-edge. I think they're aligned now. Also caught some similar issues with the stuff beneath it. > PRE-EXISTING CONDITION: Also...maybe we could get rid of the word "settings" > everywhere. So "Zoomer", "Tracking and Alignment", "Color", "Border", > "Cursor", "Cross-hair", "Advanced..." Sounds awesome to me. Done. Hey, could you do me a favor and make sure that the contracted braille widgets still work as expected? I've not gotten around to installing the latest brltty so they're all disabled for me (with and without the patch). Thanks!
(In reply to comment #5) > > Wow! The dialog fits on my Toshiba NB205 now, though that silly 612 height > > request requires me to resize it down to fit. > > And it still will. Haven't dug into that yet. Yeah it's odd. I wonder if there's some sort of hard-coded default in GTK+ that needs overriding. > > PRE-EXISTING CONDITION: The Keyboard Layout section just looks weird at the > > top. I wonder if it might look better beneath the checkboxes? > > Dunno. But done in this patch so you can see for yourself. 6 one way, half a dozen the other. :-( Given that, I guess we should go by putting the most commonly customized thing first, which is probably the keyboard layout (i.e., the way it was is probably better). > > Speech: > > ------- > ... > (There will be some translator notes that need redoing. I'll wait until we've > decided upon the language.) ... > Me neither. I redid the checkboxes in two columns. I think it helps with the > lopsidedness some. Lemme know what you think. I like the new form. Nice job, and I say go with it and update the notes to translators. > > Braille: > > -------- ... > Looks better as ASCII than in widgets. But what you propose looks far better > than what I had. Done. I think the new form looks good and the Tab order is good, too. So, I say go with it. > > Magnifier: > > ---------- ... > Heh. I didn't notice that. Sorry. Visual-spatial perception crap.... It has > since occurred to me that I could use another window as a straight-edge. I > think they're aligned now. Also caught some similar issues with the stuff > beneath it. This looks great, too. > Hey, could you do me a favor and make sure that the contracted braille widgets > still work as expected? I've not gotten around to installing the latest brltty > so they're all disabled for me (with and without the patch). Thanks! Will do. I need to test the same thing for OpenSolaris, anyway. I'll get to it tomorrow, though, since it's just about time for the big Sunday night Pokemon game. Many thanks for your nice work on this. I think this is a *huge* improvement and something that can be checked in for tomorrow's release. I'm assuming you "merely" (in quotes, because I know how much work it is to do what you did) moved things around and didn't change any of the programmatic names of the widgets? That is, the *.py and *.ui connection is still the same?
(In reply to comment #6) > (In reply to comment #5) > > > Wow! The dialog fits on my Toshiba NB205 now, though that silly 612 height > > > request requires me to resize it down to fit. > > > > And it still will. Haven't dug into that yet. > > Yeah it's odd. I wonder if there's some sort of hard-coded default in GTK+ > that needs overriding. ...or perhaps there is code in orca to set the size. :-) There's a call to self.window.resize(790, 580) in orca_gui_prefs.py around line 430 or so. Eliminating this line eliminates the problem for me. Again - many many thanks for your work!
(In reply to comment #6) > Many thanks for your nice work on this. You bet! Thanks for your help!! > I think this is a *huge* improvement Yeah, after your input and the subsequent revisions, it does look better than before. Although if Calum or other design gurus ever get really bored and want to take a stab at it, they are welcome to it. :-) > I'm assuming you > "merely" (in quotes, because I know how much work it is to do what you did) > moved things around and didn't change any of the programmatic names of the > widgets? Taking 'widgets' here very literally, you are correct. :-) There were a number of containers (vbox, hbox, table, and alignment) which had generic labels and which were not being referred to by name in our code. Some of those got proper names just to help me keep track of what was what. I'm afraid your alignment666 was a victim. > That is, the *.py and *.ui connection is still the same? Should be. After this gets committed I'll send a heads up to the list. In addition to being on the look out for regressions, a number of strings got changed and will no longer be translated until the i18n team does its thang.
Created attachment 151150 [details] [review] proposed fix * Put back the keyboard layout to where it was * Updated (and in some cases added) translator notes * Removed the hard-coded size (thanks Will!) * Pylinted and changes tested (modulo contracted braille) * Also includes a fix for the issues raised in bug 592424 Will please review. Thanks (again)!
Forgot to mention: Final resolution of dialog is now 1017x545.
Review of attachment 151150 [details] [review]: Looks good to me. I say commit. I'm still working on testing the contracted braille (looks like OpenSolaris may have a busted BrlTTY install since the brlapi python module is still being installed to python2.4 and not python2.6). Any changes we make there, however, will be a bug fix and not a GUI change.
Comment on attachment 151150 [details] [review] proposed fix Okie dokie. Patch committed to master. List warned.
(In reply to comment #11) > Review of attachment 151150 [details] [review]: > > Looks good to me. I say commit. I'm still working on testing the contracted > braille (looks like OpenSolaris may have a busted BrlTTY install since the > brlapi python module is still being installed to python2.4 and not python2.6). > Any changes we make there, however, will be a bug fix and not a GUI change. After fixing SFEliblouis.spec to use Python2.6 and using the fix I attached to http://defect.opensolaris.org/bz/show_bug.cgi?id=13784 for SUNWbrltty.spec, I can confirm that Orca does the right thing with contracted braille. :-)