After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593101 - Empathy exits sending empty /me message
Empathy exits sending empty /me message
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.27.x
Other Linux
: Normal critical
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-26 00:56 UTC by Brian Curtis
Modified: 2009-08-28 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
downstream dependencies file (5.38 KB, text/plain)
2009-08-26 00:56 UTC, Brian Curtis 		  Details
ran debug=all piped it to this file (219.88 KB, text/plain)
2009-08-26 17:48 UTC, Brian Curtis 		  Details
Fix the parsing of /commands, and put it all in one place. (4.72 KB, patch)
2009-08-27 20:21 UTC, Will Thompson 		committed Details | Review

Description Brian Curtis 2009-08-26 00:56:37 UTC 
Created attachment 141712 [details]
downstream dependencies file

Binary package hint: empathy

When I send an empty "/me" message, Empathy just closes. All Telepathy related
processes remain running.

It looks like a clean exit, because Apport is not showing. I've attached GDB
and after reproducing it I got an "Program exited with code 01" message. Since
there is no debugging symbols available to download, I don't know if this is
useful or not.

Am I the only one with this problem? Just copy "/me" and send it to someone
(tested with XMPP and MSN).

ProblemType: Bug
Architecture: i386
Date: Sun Aug 16 03:57:00 2009
DistroRelease: Ubuntu 9.10
Package: empathy 2.27.5-0ubuntu1
ProcEnviron:
 LANG=es_AR.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-5.24-generic
SourcePackage: empathy
Uname: Linux 2.6.31-5-generic i686

from downstream:
https://bugs.edge.launchpad.net/ubuntu/+source/empathy/+bug/414355
Comment 1 Guillaume Desmottes 2009-08-26 17:04:21 UTC 
Very weird bug. Could you run Empathy with EMPATHY_DEBUG=all to see what happend? Runing it in valgrind could be useful as well.
Comment 2 Brian Curtis 2009-08-26 17:24:13 UTC 
http://paste.ubuntu.com/259960
Comment 3 Pierre-Luc Beaudoin 2009-08-26 17:43:41 UTC 
hehe

the proper usage is: 
$ EMPATHY_DEBUG=all empathy

Send again please.
Comment 4 Brian Curtis 2009-08-26 17:48:58 UTC 
Created attachment 141769 [details]
ran debug=all piped it to this file
Comment 5 Will Thompson 2009-08-26 17:55:42 UTC 
empathy_message_set_body:

	if (g_str_has_prefix (body, "/me")) {
		type = TP_CHANNEL_TEXT_MESSAGE_TYPE_ACTION;
		body += 4;
	}

bzzzzzzzzzzzzzt.
Comment 6 Will Thompson 2009-08-26 18:08:34 UTC 
I'm working on this...
Comment 7 Will Thompson 2009-08-27 20:21:42 UTC 
Created attachment 141883 [details] [review]
Fix the parsing of /commands, and put it all in one place.


http://git.collabora.co.uk/?p=user/wjt/empathy.git;a=shortlog;h=refs/heads/do-say-me-think
Comment 8 Guillaume Desmottes 2009-08-28 09:50:03 UTC 
Your patch looks good. Maybe use tp_strdiff instead of strcmp?
Comment 9 Will Thompson 2009-08-28 10:23:31 UTC 
(In reply to comment #8)
> Your patch looks good. Maybe use tp_strdiff instead of strcmp?

Meh, all the functions guard against the strings being NULL already.
Comment 10 Guillaume Desmottes 2009-08-28 10:45:54 UTC 
I generally tend to always use strdiff for uniformity, safer programming and because I think it's easier/clearer to read than strcmp == 0.
But feel free to merge if you think it doesn't worth the change.
Comment 11 Will Thompson 2009-08-28 12:20:04 UTC 
Given that all the string comparisons bar one are more complicated than just "are these two strings equal?", and both functions in question guard against NULL strings, I've just merged it up. Thanks for the review!