GNOME Bugzilla – Bug 593054
By default, the display name of an account should be set to the username.
Last modified: 2009-08-31 13:55:02 UTC
When an account has been successfully created, its display name in the account list and in the dialog title should be set to the account username.
Created attachment 141670 [details] [review] Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/set-account-name src/empathy-accounts-dialog.c | 55 ++++++++++++++++++++++++++++++++++++++++- 1 files changed, 54 insertions(+), 1 deletions(-)
Comment on attachment 141670 [details] [review] Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/set-account-name >+ default_display_name = empathy_account_settings_get_string (settings, >+ "account"); I'm not sure every CM has its login name in the "account" parameter; for instance Salut does not. Maybe you should only set that if |default_display_name| is not NULL. Otherwise the patch looks good to me.
Correct not every protocol has an account name, also on irc your account name is your username, but that will be the same on every network.. Imho we should do the following * If irc use "[account] on [server]" * If there is an account property use "[account]" * If there is no account property use "[protocol] Account" Note that we should special case salut and don't allow people to create a second one, while the first one should always be called "People Nearby", but that's for another set of patches ;)
Created attachment 141776 [details] [review] Updated patch src/empathy-accounts-dialog.c | 59 ++++++++++++++++++++++++++++++++++++++++- 1 files changed, 58 insertions(+), 1 deletions(-)
Discard my last patch. I've posted it right before Sjoerd commented :)
Created attachment 141786 [details] [review] Updated patch src/empathy-accounts-dialog.c | 88 ++++++++++++++++++++++++++++++++++++++++- 1 files changed, 87 insertions(+), 1 deletions(-)
Comment on attachment 141786 [details] [review] Updated patch >+ default_display_name = >+ g_strdup_printf (_("%s on %s"), login_id, server); >+ else if (protocol != NULL) >+ { >+ default_display_name = g_strdup_printf (_("%s Account"), protocol); It would probably be good to have comments for translators before these strings. >+ empathy_account_settings_set_display_name_async (settings, >+ get_default_display_name (settings), NULL, NULL); >+ The string returned by get_default_display_name() is leaked. Apart from that, it looks good to me.
Created attachment 141851 [details] [review] Fixed patch src/empathy-accounts-dialog.c | 100 ++++++++++++++++++++++++++++++++++++++++- 1 files changed, 98 insertions(+), 2 deletions(-)
Comment on attachment 141851 [details] [review] Fixed patch Looks good, please commit to master.
Merged to master.
Created attachment 141871 [details] [review] Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/set-account-name-translator-hint Added additional informations intended to translators. src/empathy-accounts-dialog.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
Comment on attachment 141871 [details] [review] Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/set-account-name-translator-hint Looks good to commit once you have the string freeze break approved.
This bug should probably be re-opened since the additional informations intended to translators have not been merged.
Comment on attachment 141871 [details] [review] Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/set-account-name-translator-hint Pushed to master, as we got the acks from the i18n team.