After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593015 - pa_stream_flush() seems to cause sync issues
pa_stream_flush() seems to cause sync issues
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.15
Other Linux
: Normal blocker
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 592739 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-08-25 13:37 UTC by Wim Taymans
Modified: 2009-08-28 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible patch (919 bytes, patch)
2009-08-25 13:38 UTC, Wim Taymans 		none Details | Review
another patch (2.15 KB, patch)
2009-08-25 14:55 UTC, Wim Taymans 		accepted-commit_now Details | Review

Description Wim Taymans 2009-08-25 13:37:21 UTC 
It seems that after a pa_stream_flush() the pa_stream_get_time() call does not accurately report what sample is being played, this causes synchronisation problems.
Comment 1 Wim Taymans 2009-08-25 13:38:57 UTC 
Created attachment 141641 [details] [review]
possible patch

this patch disables the flush. The side effect is that sometimes old sound can be heard after a seek.
Comment 2 Wim Taymans 2009-08-25 14:55:42 UTC 
Created attachment 141653 [details] [review]
another patch

It seems the relative seeks cause us to get out of sync.
Comment 3 Tim-Philipp Müller 2009-08-25 15:30:14 UTC 
Comment on attachment 141653 [details] [review]
another patch

Seems to work well for me, let's put it in.
Comment 4 Wim Taymans 2009-08-25 15:33:44 UTC 
commit abee4f1d644dd79fe8a74884a513872ec17b5047
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Aug 25 16:53:29 2009 +0200

    pulsesink: don't use relative seeks
    
    Don't use relative seeks, it's too hard to track where we are after a flush
    etc.
    
    fixes #593015
Comment 5 Wim Taymans 2009-08-28 11:04:29 UTC 
*** Bug 592739 has been marked as a duplicate of this bug. ***