After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592945 - Images not automatically rotated
Images not automatically rotated
Status: RESOLVED INCOMPLETE
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-24 19:41 UTC by Murray Cumming
Modified: 2010-12-08 03:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add some debug output (1.58 KB, patch)
2009-08-27 08:28 UTC, Felix Riemann
rejected Details | Review

Description Murray Cumming 2009-08-24 19:41:07 UTC
In recent versions of eog (Ubuntu Jaunty's packaged version, or built-in-jhbuild), I find that eog does not automatically rotate my images when viewing a folder of images, as I navigate previous/next, though the thumbnails _are_ rotated. These are .JPG files from a Canon EOS 20D camera.

Unsetting/Setting the Automatic Orientation option makes no difference. The Reload Image plugin makes no difference either. Strangely, the image _is_ rotated if:
- It was the image that I opened eog on, for instance by right-clicking in Nautilus.
- It was previously shown via the slideshow feature. This is a very time-consuming workaround.
Comment 1 Felix Riemann 2009-08-25 17:19:15 UTC
I guess you are clicking the image in the collection, as that's the only way for me to reproduce it. Using the toolbar buttons or the keyboard rotates the image as expected here.
Comment 2 Felix Riemann 2009-08-25 18:09:06 UTC
Okay, git master should be fixed now. I have to say that's a really nice catch, thanks for the report. There were actually two problems, but fixing one would already fix/workaround the whole problem.
The first was a broken check if Exif data should be loaded besides image dimensions that would fail if the image data wasn't requested. And the second was that eog tried to autorotate the image although the metadata wasn't available. As autorotation is only done once per image the tooltip query for the collection could prevent it entirely.

commit 881fa5a4ad4f9ecd7a6d0f5415f063086813a614
Author: Felix Riemann <>
Date:   Tue Aug 25 20:00:21 2009 +0200

    Don't try to autorotate before the metadata was loaded
    
    Autorotation would fail in that case. As it is only performed once for
    each image a simple image dimension query could prevent autorotation
    entirely for an image. Fixes bgo#592945.
    
    Closes: http://bugzilla.gnome.org/show_bug.cgi?id=592945

commit 3c501d254c968bcd955194a6881c7b5bb8868c34
Author: Felix Riemann <>
Date:   Tue Aug 25 19:56:17 2009 +0200

    Fix check if only the image dimensions need to be loaded
    
    The check was assuming that if there's more requested than only image
    dimensions. This breaks with the image collection tooltips which don't
    request image data but Exif data in addition to the dimensions.
Comment 3 Murray Cumming 2009-08-26 21:34:51 UTC
> I guess you are clicking the image in the collection, as that's the only way
> for me to reproduce it. Using the toolbar buttons or the keyboard rotates the
> image as expected here.

Yes, that's what happens with the Ubuntu (Jaunty) package. 

Thanks for the very quick response and fix. However, in my jhbuild shell, I find that the rotation never ever happens in eog even when using the keyboard or toolbar buttons. The autorotate preference is checked. I guess this could be a different bug with the same symptoms.
Comment 4 Felix Riemann 2009-08-27 08:28:17 UTC
Created attachment 141830 [details] [review]
add some debug output

(In reply to comment #3)
> Thanks for the very quick response and fix. However, in my jhbuild shell, I
> find that the rotation never ever happens in eog even when using the keyboard
> or toolbar buttons. The autorotate preference is checked. I guess this could be
> a different bug with the same symptoms.

Odd. Latest git works fine here (not tried in jhbuild though).
Please apply this patch and run eog with the EOG_DEBUG_IMAGE_LOAD envvar set and post its output.

And some questions: :)

Do you have any plugins enabled?
Can you attach one of your pictures?
Comment 5 Tobias Mueller 2010-10-27 13:31:48 UTC
Murray, can you test patch #141830 and report back? TIA!
Comment 6 Fabio Durán Verdugo 2010-12-08 03:51:42 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!