After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592737 - GnomeGoal: Correct Desktop Files
GnomeGoal: Correct Desktop Files
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other All
: Normal trivial
: ---
Assigned To: empathy-maint
empathy-maint
: 590308 (view as bug list)
Depends on:
Blocks: 588975
 
 
Reported: 2009-08-22 19:05 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-08-28 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix .desktop file (705 bytes, patch)
2009-08-22 19:05 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Fix .desktop file (GNOME bug 592737) (713 bytes, patch)
2009-08-26 19:31 UTC, Frederic Peters
accepted-commit_now Details | Review

Description Javier Jardón (IRC: jjardon) 2009-08-22 19:05:00 UTC
See http://live.gnome.org/GnomeGoals/CorrectDesktopFiles
Comment 1 Javier Jardón (IRC: jjardon) 2009-08-22 19:05:44 UTC
Created attachment 141443 [details] [review]
Fix .desktop file
Comment 2 Xavier Claessens 2009-08-24 10:10:11 UTC
The patch looks good, but I think we could find a better name than "IM Client".

What about: "Chat Client" or "Chat Application"? The "IM" acronyme surely must die, and I don't really like the "Client", it don't have clear meaning to non geeks I guess...

Suggestions?
Comment 4 Guillaume Desmottes 2009-08-24 13:21:35 UTC
*** Bug 590308 has been marked as a duplicate of this bug. ***
Comment 5 Frederic Peters 2009-08-26 19:31:57 UTC
Created attachment 141785 [details] [review]
Fix .desktop file (GNOME bug 592737)
Comment 6 Frederic Peters 2009-08-26 19:33:13 UTC
Comment on attachment 141443 [details] [review]
Fix .desktop file

It was finally decided to use X-GNOME-FullName, as the key is GNOME specific (at the moment at least).

Also it's probably too late now to change from "IM Client" to something else as we are in string freeze.
Comment 7 Guillaume Desmottes 2009-08-27 14:00:00 UTC
Comment on attachment 141785 [details] [review]
Fix .desktop file (GNOME bug 592737)

Looks good. Thanks!
Comment 8 Frederic Peters 2009-08-28 12:11:10 UTC
commit b81c0c48ad7bf68583c08e38f8a2a90c7c7dce4b
Author: Frédéric Péters <fpeters@0d.be>
Date:   Wed Aug 26 21:31:11 2009 +0200

    Fix .desktop file (GNOME bug 592737)
Comment 9 Luca Ferretti 2009-08-28 12:34:44 UTC
Could we open another bug to fix the "IM Client" issue immediately on 2.29.0 ?