GNOME Bugzilla – Bug 592649
[PATCH] Open with list should be in sync with nautilus
Last modified: 2009-08-24 16:08:18 UTC
Created attachment 141380 [details] [review] Add icons to open with menu and remove "open with" prefix The "Open with" sub menu should be more like nautilus, use application icons and remove redundant "Open with" in front of the application. See [1] and [2] for more information. [1] http://bugzilla.gnome.org/show_bug.cgi?id=587533 [2] http://bugzilla.gnome.org/show_bug.cgi?id=546916
Created attachment 141381 [details] Screenshot showing icons in the menu
Comment on attachment 141380 [details] [review] Add icons to open with menu and remove "open with" prefix Generally this looks good. Optimization can happen later. Unfortunately it might be too late for 2.28 as we are already in UI freeze, and I doubt we can get freeze break approval on this one. Lucas, can you comment on this? *hope I didn't break anything. new bugzilla changed ui for setting patch status*
Just for curiosity (as I'm new to C and GTK programming) - what kind of optimizations are you talking about? The duplicity of menu paths? Or better handling of always icon as in [1]? Hope it can make it for 2.28 :) [1] http://bugzilla.gnome.org/show_bug.cgi?id=589842
Yes, I meant the menu paths. I was thinking about looping over the paths (or at least the changing first part). But as it's (hopefully) only temporary until bug 589842 lands in gtk+ (thanks for the hint), it's not really important. It's likely slower anyway.
Okay, we got the freeze break approved. So, it's in for 2.28. Thanks for the patch, Marcus. :-) commit 7bba45892744820d252fd981029ee93a22fec21e Author: Marcus Carlson <> Date: Mon Aug 24 17:47:15 2009 +0200 Make "Open with" menu look similar to Nautilus's Removes the duplicate "Open with..," prefix for menu entries and displays the application icon if available. This will make the menu look more like the "Open with" list in nautilus (not identical though). Closes: http://bugzilla.gnome.org/show_bug.cgi?id=592649 (bgo#592649). Btw, I added a follow-up commit that fixes critical warnings that could appear when no icon was available.
> Okay, we got the freeze break approved. So, it's in for 2.28. Thanks for the > patch, Marcus. :-) Great, np :) > Btw, I added a follow-up commit that fixes critical warnings that could appear > when no icon was available. Oh, sorry about that, I should have done more testing. I'll do better next time :)