After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592498 - Add upsize sampler (nohalo level 2)
Add upsize sampler (nohalo level 2)
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: GeglBuffer
git master
Other Linux
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2009-08-20 19:23 UTC by Adam Turcotte
Modified: 2010-05-21 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add upsize sampler (51.23 KB, patch)
2009-08-20 19:23 UTC, Adam Turcotte
none Details | Review
XML testcases for upsize sampler (524 bytes, application/x-gzip)
2009-08-20 19:29 UTC, Adam Turcotte
  Details
Updated version of the upsize sampler (51.25 KB, patch)
2009-08-21 17:56 UTC, Adam Turcotte
none Details | Review
Major upgrade of the gegl-sampler-upsize.c sampler (49.32 KB, patch)
2010-03-29 01:22 UTC, Nicolas Robidoux
none Details | Review
Quick visual test file for upsize sampler: enlarge car-stack 16 times (665 bytes, text/xml)
2010-03-29 02:20 UTC, Nicolas Robidoux
  Details

Description Adam Turcotte 2009-08-20 19:23:00 UTC
I have implemented the upsize sampler, which is the GEGL version of nohalo level 2.
Comment 1 Adam Turcotte 2009-08-20 19:23:44 UTC
Created attachment 141279 [details] [review]
Patch to add upsize sampler
Comment 2 Adam Turcotte 2009-08-20 19:29:40 UTC
Created attachment 141280 [details]
XML testcases for upsize sampler

These five testcases look for images big.png and small.png to be resampled using the upsize sampler.
Comment 3 Adam Turcotte 2009-08-21 17:56:13 UTC
Created attachment 141364 [details] [review]
Updated version of the upsize sampler
Comment 4 Eric Daoust 2009-08-21 19:32:20 UTC
I was successfully able to install this patch.
Comment 5 Nicolas Robidoux 2009-09-03 02:06:32 UTC
This patch is ready to commit.
Comment 6 Nicolas Robidoux 2009-09-03 21:15:34 UTC
Timing tests: Summary: upsize (Nohalo level 2) is about as fast as the current GEGL bicubic.

Details:

Colour original is a 325x325 png (the "map") except for the
downsampling tests for which the original is a 1680x1680 png (the
"baby")

reduce (downsample) a lot (gegl:scale with x=y=.061):

bicubic:    1.530s
linear:     1.376s
upsize:     1.418s

reduce (gegl:scale with x=y=.53):

bicubic:    17.856s
linear:     17.276s
upsize:     18.139s 
 
rotate (gegl:rotate with degrees=7):

bicubic:    2.054s   
linear:     1.910s
upsize:     2.084s   

enlarge (upsample) (gegl:scale with x=y=1.81):

bicubic:    2.050s
linear:     1.618s
upsize:     2.028s  

enlarge a lot (gegl:scale with x=y=5.19):

bicubic:    14.587s   
linear:     11.767s
upsize:     14.990s
Comment 7 Øyvind Kolås (pippin) 2010-02-18 14:38:41 UTC
commit 130c793c70195cf900017f74505b863a3c29a6d5
Author: Adam Turcotte <adam.turcotte@gmail.com>
Date:   Fri Jan 15 17:33:13 2010 -0500

    Add new samplers from gsoc
Comment 8 Nicolas Robidoux 2010-03-29 01:17:15 UTC
(In reply to comment #7)
> commit 130c793c70195cf900017f74505b863a3c29a6d5
> Author: Adam Turcotte <adam.turcotte@gmail.com>
> Date:   Fri Jan 15 17:33:13 2010 -0500
> 
>     Add new samplers from gsoc

My student Chantal Racette and I have programmed a new gegl-sampler-upsize.c. This version is ready for prime time. Try it! It's basically Catmull-Rom with almost no haloing and slightly reduced staircasing. Patch included.
Comment 9 Nicolas Robidoux 2010-03-29 01:22:17 UTC
Created attachment 157340 [details] [review]
Major upgrade of the gegl-sampler-upsize.c sampler

"Ready for prime time," high quality nonlinear resampler.
Comment 10 Nicolas Robidoux 2010-03-29 02:20:16 UTC
Created attachment 157341 [details]
Quick visual test file for upsize sampler: enlarge car-stack 16 times

Put this in gegl/tests/compositions and run with

gegl upsizecars.xml -o upsizecars.png
Comment 11 Nicolas Robidoux 2010-03-29 02:27:48 UTC
(In reply to comment #10)
> Created an attachment (id=157341) [details]
> Quick visual test file for upsize sampler: enlarge car-stack 16 times
> 
> Put this in gegl/tests/compositions and run with
> 
> gegl upsizecars.xml -o upsizecars.png

(Actually only 2.57 times.)
Comment 12 Nicolas Robidoux 2010-05-21 16:42:27 UTC
I'm creating a new bugzilla for the brand new upsize and upsharp.