After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592438 - "bot --step check" doesn't do anything
"bot --step check" doesn't do anything
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2009-08-20 09:58 UTC by Sascha Silbe
Modified: 2010-04-28 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix regression of #592438 caused by commit for #592433 (840 bytes, patch)
2010-01-31 11:29 UTC, Sascha Silbe
none Details | Review

Description Sascha Silbe 2009-08-20 09:58:25 UTC
With "makecheck = True" in the config, "make check" gets run during "build", but "bot --step check" just returns without doing anything:

buildslave@buildslave4:~/sugar-jhbuild$ ./sugar-jhbuild bot --step check sugar
*** success *** [1/1]
Comment 1 Frederic Peters 2009-08-20 11:28:38 UTC
commit 275caf9d0b1bfce769d3bcc2c1e3b52d29078081
Author: Frédéric Péters <fpeters@0d.be>
Date:   Thu Aug 20 13:22:54 2009 +0200

    [bot] set build step to ignore checks; and check step to always run check
    
    (GNOME bug 592438)
Comment 2 Sascha Silbe 2009-08-20 14:37:10 UTC
Works fine now, thanks!
Comment 3 Sascha Silbe 2010-01-31 11:27:06 UTC
Reopening as it got broken by commit ce1955e64f0c2611ef5ce054abd6251b1171b160 (for #592433) again. Patch attached.
Comment 4 Sascha Silbe 2010-01-31 11:29:37 UTC
Created attachment 152669 [details] [review]
fix regression of #592438 caused by commit for #592433
Comment 5 Frederic Peters 2010-04-28 11:32:31 UTC
Sorry it took so long.

commit c209f38dfc18d840840f96ffcb4dcce2add2cb2f
Author: Sascha Silbe <sascha-pgp@silbe.org>
Date:   Sun Jan 31 11:28:49 2010 +0000

    fix regression of #592438 caused by commit for #592433