After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592400 - String translation issues
String translation issues
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal critical
: ---
Assigned To: tracker-general
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2009-08-20 01:46 UTC by André Klapper
Modified: 2009-10-09 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix usage of tracker_dngettext (5.72 KB, patch)
2009-09-21 15:12 UTC, Gabor Kelemen
none Details | Review
This is what one expects to see (3.77 KB, text/plain)
2009-10-09 10:59 UTC, Gabor Kelemen
  Details
Add the po/Makevars file (285 bytes, patch)
2009-10-09 11:00 UTC, Gabor Kelemen
committed Details | Review

Description André Klapper 2009-08-20 01:46:21 UTC
In general: Please remove HTML markup where possible.
It is possible now by using GtkBuilder instead of LibGlade.


#: ../data/tracker-miner-fs.desktop.in.in.h:2
msgid "Tracker File System Miner "

#: ../src/tracker-search-tool/tracker-search-tool.c:1069
msgid "Search _results: "

Remove unused whitespace



#: ../python/deskbar-handler/tracker-handler.py:37
#: ../python/deskbar-handler/tracker-module.py:100
#, python-format
msgid "Launch %s (%s)"

#: ../python/deskbar-handler/tracker-handler.py:42
#: ../python/deskbar-handler/tracker-module.py:105
#, python-format
msgid ""
"See %s conversation\n"
"%s %s\n"
"from %s"

#: ../python/deskbar-handler/tracker-handler.py:48
#: ../python/deskbar-handler/tracker-module.py:110
#, python-format
msgid "Email from %s"

#: ../python/deskbar-handler/tracker-handler.py:61
#: ../python/deskbar-handler/tracker-module.py:122
#, python-format
msgid ""
"Listen to music %s\n"
"in %s"

#: ../python/deskbar-handler/tracker-handler.py:66
#: ../python/deskbar-handler/tracker-module.py:128
#, python-format
msgid ""
"See document %s\n"
"in %s"

#: ../python/deskbar-handler/tracker-handler.py:71
#: ../python/deskbar-handler/tracker-handler.py:88
#: ../python/deskbar-handler/tracker-handler.py:125
#: ../python/deskbar-handler/tracker-module.py:133
#: ../python/deskbar-handler/tracker-module.py:155
#: ../python/deskbar-handler/tracker-module.py:207
#: ../python/deskbar-handler/tracker-module.py:243
#, python-format
msgid ""
"Open file %s\n"
"in %s"

#: ../python/deskbar-handler/tracker-handler.py:76
#: ../python/deskbar-handler/tracker-module.py:138
#, python-format
msgid ""
"View image %s\n"
"in %s"

#: ../python/deskbar-handler/tracker-handler.py:82
#: ../python/deskbar-handler/tracker-module.py:144
#, python-format
msgid ""
"Watch video  %s\n"
"in %s"

#: ../python/deskbar-handler/tracker-handler.py:93
#: ../python/deskbar-handler/tracker-module.py:150
#, python-format
msgid ""
"Open folder %s\n"
"%s"

Please add translator comments.
http://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments



#: ../python/deskbar-handler/tracker-handler.py:211
#: ../python/deskbar-handler/tracker-module.py:351
msgid "with"

#: ../python/deskbar-handler/tracker-handler.py:219
#: ../python/deskbar-handler/tracker-module.py:359
msgid "in channel"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:586
#, c-format
msgid " taken with a <span size='large'><i>%s</i></span>"

#: ../src/tracker-search-tool/tracker-search-tool.c:670
msgid "Did you mean"

Never ever split sentences.
http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences



#: ../python/gtk-sparql/gtk-sparql.ui.h:2
msgid "gtk-delete"

#: ../python/gtk-sparql/gtk-sparql.ui.h:3
msgid "gtk-execute"

#: ../python/gtk-sparql/gtk-sparql.ui.h:4
msgid "gtk-go-back"

#: ../python/gtk-sparql/gtk-sparql.ui.h:5
msgid "gtk-go-forward"

#: ../python/gtk-sparql/gtk-sparql.ui.h:6
msgid "gtk-save"

Please unmark this noise from translation.



#: ../src/libtracker-gtk/tracker-metadata-tile.c:363
#, c-format
msgid "Path : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:364
#, c-format
msgid "Modified : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:365
#: ../src/libtracker-gtk/tracker-metadata-tile.c:547
#, c-format
msgid "Size : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:366
#, c-format
msgid "Accessed : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:367
#, c-format
msgid "Mime : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:419
#, c-format
msgid "Sender : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:420
#, c-format
msgid "Date : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:459
#, c-format
msgid "Comment : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:460
#, c-format
msgid "Categories : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:543
#: ../src/libtracker-gtk/tracker-metadata-tile.c:642
#, c-format
msgid "Duration : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:544
#, c-format
msgid "Genre : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:545
#, c-format
msgid "Bitrate : <b>%s Kbs</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:546
#, c-format
msgid "Year : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:548
#, c-format
msgid "Codec : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:611
#: ../src/libtracker-gtk/tracker-metadata-tile.c:640
#, c-format
msgid "Dimensions : <b>%d x %d</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:612
#, c-format
msgid "Date Taken : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:613
#, c-format
msgid "Orientation : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:614
#, c-format
msgid "Flash : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:615
#, c-format
msgid "Focal Length : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:616
#, c-format
msgid "Exposure Time : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:641
#: ../src/libtracker-gtk/tracker-metadata-tile.c:671
#, c-format
msgid "Author : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:643
#, c-format
msgid "Bitrate : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:644
#, c-format
msgid "Encoded In : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:645
#, c-format
msgid "Framerate : <b>%s</b>"

#. then set the remaining properties
#: ../src/libtracker-gtk/tracker-metadata-tile.c:670
#: ../src/libtracker-gtk/tracker-metadata-tile.c:700
#, c-format
msgid "Subject : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:672
#, c-format
msgid "Page Count : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:673
#, c-format
msgid "Word Count : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:674
#, c-format
msgid "Created : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-metadata-tile.c:675
#, c-format
msgid "Comments : <b>%s</b>"

#: ../src/libtracker-gtk/tracker-tag-bar.c:390
msgid "Tags :"

#: ../src/tracker-search-tool/tracker-search-tool.c:283
msgid "The following error has occurred :"

English language does not have a whitespace in front of a colon.



#: ../src/libtracker-gtk/tracker-metadata-tile.c:591
#, c-format
msgid " <span size='large'><i>%s</i></span>"

This does not make sense at all. Remove it from translation.



#: ../src/libtracker-gtk/tracker-metadata-tile.c:614
#, c-format
msgid "Flash : <b>%s</b>"

#: ../src/tracker-applet/tracker-applet-prefs.ui.h:8
msgid "_Off"

No idea how to translate. Please add translator comments.



#: ../src/tracker-applet/tracker-applet.c:295
#: ../src/tracker-search-tool/tracker-search-tool.c:1874
msgid "Indexing"

Is that a status message, or is that a header of preferences? Makes a difference in translation. Please add translator comment



#: ../src/tracker-applet/tracker-applet.c:397
#, c-format
msgid ""
"Done: %d of %d\n"
"Estimated: %s\n"
"Elapsed: %s"

"of" can have several translations, depending on what the %d's are.



re-index vs. reindex.
Please have a constant wording.



#: ../src/tracker-applet/tracker-applet.c:2337
msgid "    Folders:"

#: ../src/tracker-applet/tracker-applet.c:2338
msgid "    Documents:"

#: ../src/tracker-applet/tracker-applet.c:2339
msgid "    Images:"

#: ../src/tracker-applet/tracker-applet.c:2340
msgid "    Music:"

#: ../src/tracker-applet/tracker-applet.c:2341
msgid "    Videos:"

#: ../src/tracker-applet/tracker-applet.c:2342
msgid "    Text:"

#: ../src/tracker-applet/tracker-applet.c:2343
msgid "    Development:"

#: ../src/tracker-applet/tracker-applet.c:2344
msgid "    Other:"

Please remove whitespace from strings.



#: ../src/tracker-miner-fs/tracker-main.c:82
msgid ""
"Logging, 0 = errors only, 1 = minimal, 2 = detailed and 3 = debug (default = "
"config)"

#: ../src/tracker-miner-fs/tracker-main.c:87
msgid "Initial sleep time in seconds, 0->1000 (default = config)"

does not make sense at all. "config" is not an option available.



#: ../src/tracker-search-tool/tracker-search-tool.c:718
msgid "Tracker Search Tool-"

missing a whitespace between Tool and - ?



#. Translators: this will appear like "Search results: 5 - 10 of 30 items"
#: ../src/tracker-search-tool/tracker-search-tool.c:1600
#, c-format
msgid "%d - %d of %d items"

This is missing ngettext.



#: ../src/tracker-search-tool/tracker-search-tool.c:2106
msgid "search_entry"

What is that? A mnemonic? If so, why doesn't this have a capital letter?



#: ../src/tracker-utils/tracker-import.c:87
#: ../src/tracker-utils/tracker-info.c:114
#: ../src/tracker-utils/tracker-search.c:137
#: ../src/tracker-utils/tracker-sparql.c:120
#: ../src/tracker-utils/tracker-stats.c:78
#: ../src/tracker-utils/tracker-status.c:478
#: ../src/tracker-utils/tracker-tag.c:179
msgid "Could not establish a DBus connection to Tracker"

It's D-Bus



#: ../src/tracker-utils/tracker-info.c:148
msgid "Unable to retrieve data for uri"

#: ../src/tracker-utils/tracker-info.c:157
msgid "No metadata available for that uri"

URI instead of uri?



#: ../src/tracker-utils/tracker-info.c:164
#: ../src/tracker-utils/tracker-search.c:178
#: ../src/tracker-utils/tracker-tag.c:385
#, c-format
msgid "Result: %d"
#: ../src/tracker-utils/tracker-info.c:165
#: ../src/tracker-utils/tracker-search.c:179
#: ../src/tracker-utils/tracker-tag.c:386
#, c-format
msgid "Results: %d"

This looks a bit fishy, but I didn't check the code.
http://live.gnome.org/TranslationProject/DevGuidelines/Plurals



#: ../src/tracker-utils/tracker-processes.c:159
#, c-format
msgid "Found %d pids..."

What is that? maybe "PIDs"? what is %d here? if it's a number what if %d == 1? You miss ngettext.



#: ../src/tracker-utils/tracker-status.c:191
#, c-format
msgid "Updating '%s' with new count:%s"
msgstr ""

#: ../src/tracker-utils/tracker-status.c:217
#, c-format
msgid "Processed %d/%d, current service:'%s', %s left, %s elapsed"

Missing whitespaces after the colon



#: ../src/tracker-utils/tracker-status.c:254
#, c-format
msgid "Tracker status changed from '%s' --> '%s'"

Please use a proper sentence - "to" instead of "-->"



#: ../src/tracker-utils/tracker-status.c:292
msgid "Is paused for IO"

No idea how to properly translate this, and how an average english user should understand this at all.



All those msgid's that start with
"- 
Sometimes you use capitalization, sometimes not.
Comment 1 André Klapper 2009-09-20 13:37:38 UTC
This also does not work at all:

#: ../src/tracker-utils/tracker-search.c:304
#, c-format
msgid "%d Song"

#: ../src/tracker-utils/tracker-search.c:305
#, c-format
msgid "%d Songs"

#: ../src/tracker-utils/tracker-search.c:311
#, c-format
msgid "%d Second"

#: ../src/tracker-utils/tracker-search.c:312
#, c-format
msgid "%d Seconds"

The code does use "tracker_dngettext" but whatever that is it is obviously broken.

Without any fixing of the issues listed here I refuse to make tracker part of GNOME.
Comment 2 Gabor Kelemen 2009-09-20 15:33:35 UTC
We already have bug #591814 is about removing unused markup :).

And some more: 

#: ../src/libtracker-miner/tracker-miner.c:686
Pause application and reason match an already existing pause request

This doesn't make any sense to me. Perhaps "Pause request..."?

#: ../src/tracker-preferences/tracker-preferences.ui.h:30
This is an exception to the previous option. \n

Please remove extra whitespace after the period.
Comment 3 Gabor Kelemen 2009-09-20 15:58:55 UTC
Last one for today:

#: ../src/tracker-utils/tracker-status.c:206
Could not DBusGProxy for that miner: %s

Please rephrase this.
Comment 4 Martyn Russell 2009-09-21 08:45:49 UTC
(In reply to comment #3)
> Last one for today:
> 
> #: ../src/tracker-utils/tracker-status.c:206
> Could not DBusGProxy for that miner: %s
> 
> Please rephrase this.

I have just improved this string. Thanks for noticing!
Comment 5 Martyn Russell 2009-09-21 09:35:53 UTC
(In reply to comment #0)
> In general: Please remove HTML markup where possible.
> It is possible now by using GtkBuilder instead of LibGlade.
> 
> 
> #: ../data/tracker-miner-fs.desktop.in.in.h:2
> msgid "Tracker File System Miner "

Fixed.
 
> #: ../src/tracker-search-tool/tracker-search-tool.c:1069
> msgid "Search _results: "
> 
> Remove unused whitespace

WONTFIX, Jamie is working on TST right now so I want to avoid conflicts. This is likely obsolete now anyway.
 
> #: ../python/deskbar-handler/tracker-handler.py:37
> #: ../python/deskbar-handler/tracker-module.py:100
> #, python-format
> msgid "Launch %s (%s)"
> 
> #: ../python/deskbar-handler/tracker-handler.py:42
> #: ../python/deskbar-handler/tracker-module.py:105
> #, python-format
> msgid ""
> "See %s conversation\n"
> "%s %s\n"
> "from %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:48
> #: ../python/deskbar-handler/tracker-module.py:110
> #, python-format
> msgid "Email from %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:61
> #: ../python/deskbar-handler/tracker-module.py:122
> #, python-format
> msgid ""
> "Listen to music %s\n"
> "in %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:66
> #: ../python/deskbar-handler/tracker-module.py:128
> #, python-format
> msgid ""
> "See document %s\n"
> "in %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:71
> #: ../python/deskbar-handler/tracker-handler.py:88
> #: ../python/deskbar-handler/tracker-handler.py:125
> #: ../python/deskbar-handler/tracker-module.py:133
> #: ../python/deskbar-handler/tracker-module.py:155
> #: ../python/deskbar-handler/tracker-module.py:207
> #: ../python/deskbar-handler/tracker-module.py:243
> #, python-format
> msgid ""
> "Open file %s\n"
> "in %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:76
> #: ../python/deskbar-handler/tracker-module.py:138
> #, python-format
> msgid ""
> "View image %s\n"
> "in %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:82
> #: ../python/deskbar-handler/tracker-module.py:144
> #, python-format
> msgid ""
> "Watch video  %s\n"
> "in %s"
> 
> #: ../python/deskbar-handler/tracker-handler.py:93
> #: ../python/deskbar-handler/tracker-module.py:150
> #, python-format
> msgid ""
> "Open folder %s\n"
> "%s"
> 
> Please add translator comments.
> http://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments

The deskbar work is quite old. I am not going to change this right now since the code generally needs improving here.
 
> #: ../python/deskbar-handler/tracker-handler.py:211
> #: ../python/deskbar-handler/tracker-module.py:351
> msgid "with"
> 
> #: ../python/deskbar-handler/tracker-handler.py:219
> #: ../python/deskbar-handler/tracker-module.py:359
> msgid "in channel"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:586
> #, c-format
> msgid " taken with a <span size='large'><i>%s</i></span>"
> 
> #: ../src/tracker-search-tool/tracker-search-tool.c:670
> msgid "Did you mean"
> 
> Never ever split sentences.
> http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences

Yea, I normally wouldn't.

> #: ../python/gtk-sparql/gtk-sparql.ui.h:2
> msgid "gtk-delete"
> 
> #: ../python/gtk-sparql/gtk-sparql.ui.h:3
> msgid "gtk-execute"
> 
> #: ../python/gtk-sparql/gtk-sparql.ui.h:4
> msgid "gtk-go-back"
> 
> #: ../python/gtk-sparql/gtk-sparql.ui.h:5
> msgid "gtk-go-forward"
> 
> #: ../python/gtk-sparql/gtk-sparql.ui.h:6
> msgid "gtk-save"
> 
> Please unmark this noise from translation.

Hmm, well, there is no gtk-sparql.ui.h any more as far as I could see. Also those are in the .ui file now and NOT marked as translatable so they shouldn't appear.

> #: ../src/libtracker-gtk/tracker-metadata-tile.c:363
> #, c-format
> msgid "Path : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:364
> #, c-format
> msgid "Modified : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:365
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:547
> #, c-format
> msgid "Size : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:366
> #, c-format
> msgid "Accessed : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:367
> #, c-format
> msgid "Mime : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:419
> #, c-format
> msgid "Sender : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:420
> #, c-format
> msgid "Date : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:459
> #, c-format
> msgid "Comment : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:460
> #, c-format
> msgid "Categories : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:543
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:642
> #, c-format
> msgid "Duration : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:544
> #, c-format
> msgid "Genre : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:545
> #, c-format
> msgid "Bitrate : <b>%s Kbs</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:546
> #, c-format
> msgid "Year : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:548
> #, c-format
> msgid "Codec : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:611
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:640
> #, c-format
> msgid "Dimensions : <b>%d x %d</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:612
> #, c-format
> msgid "Date Taken : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:613
> #, c-format
> msgid "Orientation : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:614
> #, c-format
> msgid "Flash : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:615
> #, c-format
> msgid "Focal Length : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:616
> #, c-format
> msgid "Exposure Time : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:641
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:671
> #, c-format
> msgid "Author : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:643
> #, c-format
> msgid "Bitrate : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:644
> #, c-format
> msgid "Encoded In : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:645
> #, c-format
> msgid "Framerate : <b>%s</b>"
> 
> #. then set the remaining properties
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:670
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:700
> #, c-format
> msgid "Subject : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:672
> #, c-format
> msgid "Page Count : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:673
> #, c-format
> msgid "Word Count : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:674
> #, c-format
> msgid "Created : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:675
> #, c-format
> msgid "Comments : <b>%s</b>"
> 
> #: ../src/libtracker-gtk/tracker-tag-bar.c:390
> msgid "Tags :"
> 
> #: ../src/tracker-search-tool/tracker-search-tool.c:283
> msgid "The following error has occurred :"
> 
> English language does not have a whitespace in front of a colon.

I agree, this is quite old - even obsolete you could say. I am not changing this because it hasn't yet been decided if we will keep it.
 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:591
> #, c-format
> msgid " <span size='large'><i>%s</i></span>"
> 
> This does not make sense at all. Remove it from translation.

Same as above.
 
> #: ../src/libtracker-gtk/tracker-metadata-tile.c:614
> #, c-format
> msgid "Flash : <b>%s</b>"
> 
> #: ../src/tracker-applet/tracker-applet-prefs.ui.h:8
> msgid "_Off"
> 
> No idea how to translate. Please add translator comments.

Same as above.

> #: ../src/tracker-applet/tracker-applet.c:295
> #: ../src/tracker-search-tool/tracker-search-tool.c:1874
> msgid "Indexing"
> 
> Is that a status message, or is that a header of preferences? Makes a
> difference in translation. Please add translator comment

Same as above.
 
> #: ../src/tracker-applet/tracker-applet.c:397
> #, c-format
> msgid ""
> "Done: %d of %d\n"
> "Estimated: %s\n"
> "Elapsed: %s"
> 
> "of" can have several translations, depending on what the %d's are.

Obsolete.
 
> #: ../src/tracker-applet/tracker-applet.c:2337
> msgid "    Folders:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2338
> msgid "    Documents:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2339
> msgid "    Images:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2340
> msgid "    Music:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2341
> msgid "    Videos:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2342
> msgid "    Text:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2343
> msgid "    Development:"
> 
> #: ../src/tracker-applet/tracker-applet.c:2344
> msgid "    Other:"
> 
> Please remove whitespace from strings.

Obsolete.

> #: ../src/tracker-miner-fs/tracker-main.c:82
> msgid ""
> "Logging, 0 = errors only, 1 = minimal, 2 = detailed and 3 = debug (default = "
> "config)"
> 
> #: ../src/tracker-miner-fs/tracker-main.c:87
> msgid "Initial sleep time in seconds, 0->1000 (default = config)"
> 
> does not make sense at all. "config" is not an option available.

Great find. I have fixed this!

> #: ../src/tracker-search-tool/tracker-search-tool.c:718
> msgid "Tracker Search Tool-"
> 
> missing a whitespace between Tool and - ?

Obsolete. Might get replaced this week.

> #. Translators: this will appear like "Search results: 5 - 10 of 30 items"
> #: ../src/tracker-search-tool/tracker-search-tool.c:1600
> #, c-format
> msgid "%d - %d of %d items"
> 
> This is missing ngettext.

Obsolete. Might get replaced this week.

> #: ../src/tracker-search-tool/tracker-search-tool.c:2106
> msgid "search_entry"
> 
> What is that? A mnemonic? If so, why doesn't this have a capital letter?

Obsolete. Might get replaced this week.

> #: ../src/tracker-utils/tracker-import.c:87
> #: ../src/tracker-utils/tracker-info.c:114
> #: ../src/tracker-utils/tracker-search.c:137
> #: ../src/tracker-utils/tracker-sparql.c:120
> #: ../src/tracker-utils/tracker-stats.c:78
> #: ../src/tracker-utils/tracker-status.c:478
> #: ../src/tracker-utils/tracker-tag.c:179
> msgid "Could not establish a DBus connection to Tracker"
> 
> It's D-Bus

OK, fixed, that's quite a lot of changes though :)
 
> #: ../src/tracker-utils/tracker-info.c:148
> msgid "Unable to retrieve data for uri"
> 
> #: ../src/tracker-utils/tracker-info.c:157
> msgid "No metadata available for that uri"
> 
> URI instead of uri?

Fixed.

> #: ../src/tracker-utils/tracker-info.c:164
> #: ../src/tracker-utils/tracker-search.c:178
> #: ../src/tracker-utils/tracker-tag.c:385
> #, c-format
> msgid "Result: %d"
> #: ../src/tracker-utils/tracker-info.c:165
> #: ../src/tracker-utils/tracker-search.c:179
> #: ../src/tracker-utils/tracker-tag.c:386
> #, c-format
> msgid "Results: %d"
> 
> This looks a bit fishy, but I didn't check the code.
> http://live.gnome.org/TranslationProject/DevGuidelines/Plurals

Why? Not sure what you think is incorrect here. I am using plurals correctly. We use our own in-house function because Glib didn't have the version we wanted at the time we wrote it.

> #: ../src/tracker-utils/tracker-processes.c:159
> #, c-format
> msgid "Found %d pids..."
> 
> What is that? maybe "PIDs"? what is %d here? if it's a number what if %d == 1?
> You miss ngettext.

You're right, although technically, having 1 process is almost completely impossible ;)

Fixed.

> #: ../src/tracker-utils/tracker-status.c:191
> #, c-format
> msgid "Updating '%s' with new count:%s"
> msgstr ""
> 
> #: ../src/tracker-utils/tracker-status.c:217
> #, c-format
> msgid "Processed %d/%d, current service:'%s', %s left, %s elapsed"
> 
> Missing whitespaces after the colon

These are no longer in the code.
 
> #: ../src/tracker-utils/tracker-status.c:254
> #, c-format
> msgid "Tracker status changed from '%s' --> '%s'"
> 
> Please use a proper sentence - "to" instead of "-->"

This is no longer in the code.

> #: ../src/tracker-utils/tracker-status.c:292
> msgid "Is paused for IO"
> 
> No idea how to properly translate this, and how an average english user should
> understand this at all.

This is no longer in the code.

> All those msgid's that start with
> "- 
> Sometimes you use capitalization, sometimes not.

Yes, that depends I think.

Thanks for noticing these.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 André Klapper 2009-09-21 10:14:55 UTC
Thanks for fixing a lot of stuff!

(In reply to comment #5)
> > #: ../src/tracker-search-tool/tracker-search-tool.c:1069
> > msgid "Search _results: "
> > 
> > Remove unused whitespace
> 
> WONTFIX, Jamie is working on TST right now so I want to avoid conflicts. This
> is likely obsolete now anyway.

And as long as TST work hasn't finished it's still valid, so I don't get the point of closing this bug report.

> The deskbar work is quite old. I am not going to change this right now since
> the code generally needs improving here.

And when somebody improves the code he will forget about the strings, as this bug report is already closed anyway though these issues are still valid.

> > Never ever split sentences.
> > http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences
> 
> Yea, I normally wouldn't.

Which means...? "Not fixable"? If so, why?

> > English language does not have a whitespace in front of a colon.
> 
> I agree, this is quite old - even obsolete you could say. I am not changing
> this because it hasn't yet been decided if we will keep it.

Still it's currently valid. And if it has not been decided yet it's even more valid to keep this open. Because if the decision is to keep it this bug report is still closed.

> > #. Translators: this will appear like "Search results: 5 - 10 of 30 items"
> > #: ../src/tracker-search-tool/tracker-search-tool.c:1600
> > #, c-format
> > msgid "%d - %d of %d items"
> > 
> > This is missing ngettext.
> 
> Obsolete. Might get replaced this week.

Code is still wrong and does not work for some languages:
if (count > 5) {
/* Translators: this will appear like "Search results: 5 - 10 of 30 items" */
label_str = g_strdup_printf (_("%d - %d of %d items"), from, to, count);
Comment 7 Gabor Kelemen 2009-09-21 15:09:26 UTC
(In reply to comment #5)
> > #: ../src/tracker-utils/tracker-info.c:164
> > #: ../src/tracker-utils/tracker-search.c:178
> > #: ../src/tracker-utils/tracker-tag.c:385
> > #, c-format
> > msgid "Result: %d"
> > #: ../src/tracker-utils/tracker-info.c:165
> > #: ../src/tracker-utils/tracker-search.c:179
> > #: ../src/tracker-utils/tracker-tag.c:386
> > #, c-format
> > msgid "Results: %d"
> > 
> > This looks a bit fishy, but I didn't check the code.
> > http://live.gnome.org/TranslationProject/DevGuidelines/Plurals
> 
> Why? Not sure what you think is incorrect here. I am using plurals correctly.
> We use our own in-house function because Glib didn't have the version we wanted
> at the time we wrote it.
> 

The problem with this is that it does not work as expected. If you use ngettext correctly, it looks like this in the po file:

#: ../src/libtracker-common/tracker-utils.c:190
#, c-format
msgid " %d day"
msgid_plural " %d days"
msgstr[0] ""
msgstr[1] ""

In this case, there are two problems: one is that the i18n infrastructure does not know about the tracker_dngettext function, the other is that the strings are in the _() macro, so they are treated as single strings.
Comment 8 Gabor Kelemen 2009-09-21 15:12:57 UTC
Created attachment 143610 [details] [review]
Fix usage of tracker_dngettext

This patch adds a Makevars file, which tells intltool that it should check this function too. Other parts remove unneeded _() calls from tracker_dngettext calls. 
Now I have: 

#: ../src/tracker-utils/tracker-info.c:164
#: ../src/tracker-utils/tracker-search.c:513
#: ../src/tracker-utils/tracker-sparql.c:402
#: ../src/tracker-utils/tracker-tag.c:386
#, c-format
msgid "Result: %d"
msgid_plural "Results: %d"
msgstr[0] ""
msgstr[1] ""
Comment 9 Martyn Russell 2009-09-25 23:04:00 UTC
(In reply to comment #8)
> Created an attachment (id=143610) [details]
> Fix usage of tracker_dngettext
> 
> This patch adds a Makevars file, which tells intltool that it should check this
> function too. Other parts remove unneeded _() calls from tracker_dngettext
> calls. 
> Now I have: 
> 
> #: ../src/tracker-utils/tracker-info.c:164
> #: ../src/tracker-utils/tracker-search.c:513
> #: ../src/tracker-utils/tracker-sparql.c:402
> #: ../src/tracker-utils/tracker-tag.c:386
> #, c-format
> msgid "Result: %d"
> msgid_plural "Results: %d"
> msgstr[0] ""
> msgstr[1] ""

Regarding comment 7 and 8, this was fixed recently. Thank you for the patch, but it was done before that was seem.

(In reply to comment #6)
> Thanks for fixing a lot of stuff!

No problem.
 
> (In reply to comment #5)
> > > #: ../src/tracker-search-tool/tracker-search-tool.c:1069
> > > msgid "Search _results: "
> > > 
> > > Remove unused whitespace
> > 
> > WONTFIX, Jamie is working on TST right now so I want to avoid conflicts. This
> > is likely obsolete now anyway.
> 
> And as long as TST work hasn't finished it's still valid, so I don't get the
> point of closing this bug report.

No, it is not valid in this case. TST has been completely rewritten, so this translation will _NEVER_ be used again.
 
> > The deskbar work is quite old. I am not going to change this right now since
> > the code generally needs improving here.
> 
> And when somebody improves the code he will forget about the strings, as this
> bug report is already closed anyway though these issues are still valid.

Well, the simple answer here is, we just don't have enough resources to fix the deskbar work. So this is a WONTFIX for now.

> > > Never ever split sentences.
> > > http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences
> > 
> > Yea, I normally wouldn't.
> 
> Which means...? "Not fixable"? If so, why?

Which means, I don't do this and I think what you are seeing is some legacy code which we are not likely to change any time soon, much like the problems in deskbar.

> > > English language does not have a whitespace in front of a colon.
> > 
> > I agree, this is quite old - even obsolete you could say. I am not changing
> > this because it hasn't yet been decided if we will keep it.
> 
> Still it's currently valid. And if it has not been decided yet it's even more
> valid to keep this open. Because if the decision is to keep it this bug report
> is still closed.

No it isn't. This code no longer exists so it is completely invalid.
 
> > > #. Translators: this will appear like "Search results: 5 - 10 of 30 items"
> > > #: ../src/tracker-search-tool/tracker-search-tool.c:1600
> > > #, c-format
> > > msgid "%d - %d of %d items"
> > > 
> > > This is missing ngettext.
> > 
> > Obsolete. Might get replaced this week.
> 
> Code is still wrong and does not work for some languages:
> if (count > 5) {
> /* Translators: this will appear like "Search results: 5 - 10 of 30 items" */
> label_str = g_strdup_printf (_("%d - %d of %d items"), from, to, count);

As said, this has been rewritten from scratch so no longer exists.

--

Since we won't be fixing the deskbar issues any time soon, I am marking this as WONTFIX. Feel free to reopen it if you have a patch to resolve this.
Comment 10 Gabor Kelemen 2009-09-26 10:27:03 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > Created an attachment (id=143610) [details] [details]
> > Fix usage of tracker_dngettext
> > 
> > This patch adds a Makevars file, which tells intltool that it should check this
> > function too. Other parts remove unneeded _() calls from tracker_dngettext
> > calls. 
> > Now I have: 
> > 
> > #: ../src/tracker-utils/tracker-info.c:164
> > #: ../src/tracker-utils/tracker-search.c:513
> > #: ../src/tracker-utils/tracker-sparql.c:402
> > #: ../src/tracker-utils/tracker-tag.c:386
> > #, c-format
> > msgid "Result: %d"
> > msgid_plural "Results: %d"
> > msgstr[0] ""
> > msgstr[1] ""
> 
> Regarding comment 7 and 8, this was fixed recently. Thank you for the patch,
> but it was done before that was seem.
> 

Only partially, so reopening.
My patch has two parts, one removes unneeded _() macros - this is already committed, the other adds a po/Makevars file, which makes intltool know about your custom function. This is also necessary to extract those strings. 

If you currently run intltool-update -p and grep for Result: in the resulting tracker.pot, you won't see the above excerpt.

So, until glib 2.18 and g_dngettext is not usable, please add the Makevars file.
Comment 11 Martyn Russell 2009-10-09 09:40:15 UTC
Since the _() macros have been fixed already and running intltool-update -p produces no output or new files, I am marking this as WONTFIX again.
Comment 12 Gabor Kelemen 2009-10-09 10:59:06 UTC
Created attachment 145117 [details]
This is what one expects to see

Ok, probably I was not clear enough: adding the Makevars file produces this diff in the pot file. This way the strings appear, otherwise they don't.
Comment 13 Gabor Kelemen 2009-10-09 11:00:54 UTC
Created attachment 145119 [details] [review]
Add the po/Makevars file
Comment 14 Martyn Russell 2009-10-09 11:23:03 UTC
Comment on attachment 145119 [details] [review]
Add the po/Makevars file

Thanks for the patch!
Comment 15 Martyn Russell 2009-10-09 11:23:14 UTC
Fixed