After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592372 - Play shutter sound effect through libcanberra
Play shutter sound effect through libcanberra
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: screenshot
trunk
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-19 19:05 UTC by William Jon McCann
Modified: 2009-09-25 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.48 KB, patch)
2009-08-23 20:29 UTC, William Jon McCann
needs-work Details | Review

Description William Jon McCann 2009-08-19 19:05:17 UTC
We shoud play a shutter sound effect through libcanberra when taking a screenshot.
Comment 1 William Jon McCann 2009-08-23 20:29:27 UTC
Created attachment 141506 [details] [review]
patch

Adds a string so can we please get this in by tomorrow?
Comment 2 Cosimo Cecchi 2009-08-23 23:37:33 UTC
Comment on attachment 141506 [details] [review]
patch

Hi Jon, thanks for the patch.
Two comments:

> # common checks
> PKG_CHECK_MODULES(GNOME_UTILS, glib-2.0 >= $GLIB_REQUIRED dnl
>                                gio-2.0 >= $GIO_REQUIRED   dnl
>                                gconf-2.0                  dnl
>+                               libcanberra-gtk >= $LIBCANBERRA_GTK_REQUIRED dnl

Could you please split this into a separate PKG_CHECK_MODULES section, like we do for libgtop (and add the relevant CFLAGS/LIBS variables to gnome-screenshot/Makefile.am)?

> static void
>+sound_effect_finished (ca_context *c,
>+                       uint32_t    id,
>+                       int         error_code,
>+                       void       *userdata)
>+{
>+}

Can't you just pass NULL to the callback and avoid this?

With these fixed, the patch looks fine to me.
Comment 3 William Jon McCann 2009-08-24 00:00:26 UTC
Pushed with those changes.  Thanks for the quick review!
Comment 4 antistress 2009-09-24 18:23:12 UTC
is it in GNOME 2.28 ? i don't hear anything with Ubuntu Karmic alpha 6 up to date
Comment 5 Cosimo Cecchi 2009-09-24 23:53:55 UTC
(In reply to comment #4)
> is it in GNOME 2.28 ? i don't hear anything with Ubuntu Karmic alpha 6 up to
> date

Hi, yes it's in 2.28. You might be missing the "screen-capture" sound from the  sound theme installed in your distro.
Comment 6 antistress 2009-09-25 00:04:27 UTC
thanks, i've reported the bug against Ubuntu then
( https://bugs.launchpad.net/ubuntu/+source/ubuntu-sounds/+bug/436291 )