GNOME Bugzilla – Bug 592349
Add downsharpfast, downsizefast, downsmoothfast samplers
Last modified: 2010-02-18 14:37:54 UTC
Downsharpfast: faster version of Downsharp Downsizefast: faster version of Downsize Downsmoothfast; faster version of Downsmooth
Created attachment 141170 [details] [review] Patch implementing the three samplers This patch implements the three downsamplers.
Created attachment 141249 [details] Test files for downsharpfast Test xml files uses two of your own images: big.png: a larger image, preferably 1500x1500 or larger small.png: a much smaller image (mine was about 300x300)
Created attachment 141250 [details] Test files for downsizefast Test xml files uses two of your own images: big.png: a larger image, preferably 1500x1500 or larger small.png: a much smaller image (mine was about 300x300)
Created attachment 141251 [details] Test files for downsmoothfast Test xml files uses two of your own images: big.png: a larger image, preferably 1500x1500 or larger small.png: a much smaller image (mine was about 300x300)
In the mild downsmoothfast downsamples from the gallery http://socghop.appspot.com/document/show/user/ericdaoust/gsoc I see glitches similar to those which Adam Turcotte discovered in his own downsamplers (which are "higher level" versions of Eric Daoust's), and which he fixed by adding an extra "one pixel wide unused (in principle) border" to the context_rect. There are few additional changes which are required as a result of changing the context_rect. We have only seen the glitches for very mild downsampling ratios (about half). This, most likely, is because they are "blurred away" when the downsampling ratio is large enough, and because, when upsampling, the context_rect is not changed by the "_get" method. IMHO the simplest way to deal with this is to have Adam have a patch to Eric's patch which implements the fix, since he did it already for his own downsamplers. So: Adam, can you do with Eric's downsamplers as you did for yours, please, and put the "patch to the patch" here? (Note: Adam and I suspect that the glitches are not internal to our samplers but come from some subtle quirk in the buffer or affine code.) Nicolas Robidoux Universite Laurentienne
commit 130c793c70195cf900017f74505b863a3c29a6d5 Author: Adam Turcotte <adam.turcotte@gmail.com> Date: Fri Jan 15 17:33:13 2010 -0500 Add new samplers from gsoc