After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592232 - [qtdemux] QT style string tag extraction fails
[qtdemux] QT style string tag extraction fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-18 15:36 UTC by Mark Nauwelaerts
Modified: 2009-08-18 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use guint32 for tag fourcc (769 bytes, patch)
2009-08-18 15:36 UTC, Mark Nauwelaerts 		accepted-commit_now Details | Review

Description Mark Nauwelaerts 2009-08-18 15:36:28 UTC 
Created attachment 141087 [details] [review]
Use guint32 for tag fourcc

Apple trailers have some tags stored in QT style format, which a.o. means
fourcc starts with (C) symbol.  A specific code path tests for this using:
    if ((type >> 24) == 0xa9)
However, type is int, so sign-extension messes with shift and subsequent
comparison.
Comment 1 Tim-Philipp Müller 2009-08-18 16:12:06 UTC 
Comment on attachment 141087 [details] [review]
Use guint32 for tag fourcc

Nice catch indeed. I think what happens to the highest bit here is basically undefined according to the standard(s).

Please commit.
Comment 2 Mark Nauwelaerts 2009-08-18 17:08:11 UTC 
commit 15d17763c0c8a89ef3e65a9ae1252f1aa1449a94
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Aug 18 17:16:11 2009 +0200

    qtdemux: fix qt style string tag extraction

    QT style tags are tested on starting with (C) symbol using >>,
    and (unsigned) int (may) have different >> behaviour.
    Fixes #592232.