After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592159 - Support multiple factories for address-book with dbus
Support multiple factories for address-book with dbus
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other Linux
: Immediate blocker
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[dbus]
Depends on:
Blocks:
 
 
Reported: 2009-08-18 04:25 UTC by Chenthill P
Modified: 2009-10-23 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed eds patch (14.76 KB, patch)
2009-10-05 18:36 UTC, Milan Crha 		committed Details | Review

Description Chenthill P 2009-08-18 04:25:53 UTC 
With dbus support for multiple factories has been removed. Backends such as exchange would need multiple factories so that they can run in a separate address-space.
Comment 1 Milan Crha 2009-10-05 18:36:32 UTC 
Created attachment 144826 [details] [review]
proposed eds patch

for evolution-data-server;

Did you mean something like this?

(Note there are also some warnings changes and other things changed I didn't like. Also note that I had a little chat with Ross and he suggested to have some generic EDataFactory, which will cover same parts from cal and book factories, each other will change/reimplement only parts which are different. As some next step.)
Comment 2 Milan Crha 2009-10-14 12:58:29 UTC 
Chen, ping.

This also fixes issues with book_destroy_cb callback, access of an invalid pointer. I'm going to commit in a week or so, to have it in 2.29.1?
Comment 3 Milan Crha 2009-10-16 12:46:14 UTC 
As I believe this is a correct patch, and it fixes few things too, and considering this is a blocker bug:

Created commit b1a100a in eds master (2.29.1+)
Comment 4 Chenthill P 2009-10-23 10:11:59 UTC 
This bug was primarily intended for backends like exchange which can run in a different address-space. But since exchange is made similar to other plugable backends in eds, this is not needed right now. iirc i had a discussion with matt in some other bug..