After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592005 - Unmark for translation: 'gtk-add', 'gtk-remove' and 'gtk-leave-fullscreen'
Unmark for translation: 'gtk-add', 'gtk-remove' and 'gtk-leave-fullscreen'
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-16 20:32 UTC by Tommi Vainikainen
Modified: 2009-08-20 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stock button labels should not be translatable (1.76 KB, patch)
2009-08-17 21:31 UTC, Christian Kirbach
committed Details | Review

Description Tommi Vainikainen 2009-08-16 20:32:13 UTC
While translating Empathy I found following three strings:

#: ../libempathy-gtk/empathy-status-preset-dialog.ui.h:3
msgid "gtk-add"
msgstr ""

#: ../libempathy-gtk/empathy-status-preset-dialog.ui.h:4
msgid "gtk-remove"
msgstr ""

#: ../src/empathy-call-window-fullscreen.ui.h:1
msgid "gtk-leave-fullscreen"
msgstr ""

I don't know how to translate these. I assume these are GTK+ signal names, and should not be translated. If so, those should be unmarked as translatable.
If those are really meant to be translated, please add translator comment explaining how to translate those.

PS. There was also string "Pause" which could be enhanced by adding message context whether it is verb or noun...
Comment 1 André Klapper 2009-08-17 09:49:34 UTC
Please simply ignore them.
They should not be translated at all.
For future reference, please add the L10N keyword (and "string" if it changes or adds new strings)
Comment 2 Christian Kirbach 2009-08-17 21:27:49 UTC
Ignore them?Nuke them instead!
They should not be translatable at all.
Comment 3 Christian Kirbach 2009-08-17 21:31:29 UTC
Created attachment 140997 [details] [review]
stock button labels should not be translatable
Comment 4 Guillaume Desmottes 2009-08-18 09:09:16 UTC
Looks good. Please commit.
Comment 5 Guillaume Desmottes 2009-08-20 09:42:27 UTC
Comment on attachment 140997 [details] [review]
stock button labels should not be translatable

I commited it for you. Thanks for the patch!