Bug 591951 – pipelines/simple-launch-lines check segfaults with libjpeg 7

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 591951 - pipelines/simple-launch-lines check segfaults with libjpeg 7


Summary:	pipelines/simple-launch-lines check segfaults with libjpeg 7


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-good
Version:	git master
Hardware:	Other Linux

Importance:	Normal blocker
Target Milestone:	0.10.16
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-08-16 10:13 UTC by Götz Waschk
Modified:	2009-08-17 16:11 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
possible fix (514 bytes, patch) 2009-08-17 10:40 UTC, Tim-Philipp Müller	committed	Details \| Review

Description Götz Waschk 2009-08-16 10:13:45 UTC

This is on Mandriva Cooker with gst-plugins-good 0.10.15.3 and libjpeg 7:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 216946

Thread 1084160880 (LWP 2029)

#0 jpeg_fdct_16x16
at jfdctint.c line 2188
#1 forward_DCT
at jcdctmgr.c line 82
#2 compress_data
at jccoefct.c line 180
#3 jpeg_write_raw_data
at jcapistd.c line 153
#4 smokecodec_encode
at smokecodec.c line 519
#5 gst_smokeenc_chain
at gstsmokeenc.c line 409
#6 gst_pad_chain_data_unchecked
at gstpad.c line 4057
#7 gst_pad_push_data
at gstpad.c line 4287
#8 gst_base_src_loop
at gstbasesrc.c line 2323
#9 gst_task_func
at gsttask.c line 234
#10 default_func
at gsttaskpool.c line 70
#11 g_thread_pool_thread_proxy
at gthreadpool.c line 265
#12 g_thread_create_proxy
at gthread.c line 635
#13 start_thread
from /lib/i686/libpthread.so.0
#14 clone
at ../sysdeps/unix/sysv/linux/i386/clone.S line 130

Comment 1 Tim-Philipp Müller 2009-08-17 10:40:18 UTC

Created attachment 140953 [details] [review]
possible fix

Could you try this?

Comment 2 Götz Waschk 2009-08-17 10:56:08 UTC

This patch prevents the crash.

Comment 3 Tim-Philipp Müller 2009-08-17 16:11:10 UTC

Great, thanks!

 commit 68c4019057b5f9090622c9d5eb3f6b4cb947c2a0
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Mon Aug 17 15:48:20 2009 +0100

    smokeenc: don't crash when compiled against libjpeg7
    
    Set parameters so that we don't crash with libjpeg7. Based on
    Stefan Kost's fix for jpegenc. Fixes #591951.