After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591899 - autoconf-2.64 compat: Don't use $(builddir)
autoconf-2.64 compat: Don't use $(builddir)
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-08-15 13:18 UTC by Owen Taylor
Modified: 2015-02-07 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
autoconf-2.64 compat: Don't use $(builddir) (1.89 KB, patch)
2009-08-15 13:18 UTC, Owen Taylor
none Details | Review

Description Owen Taylor 2009-08-15 13:18:02 UTC
$(builddir) is not a standard automake variable. With autoconf < 2.64
it ends up getting set in every Makefile.in to '.' (because autoconf
defines it), but that is no longer the case for 2.64.

 * We don't need $(builddir) in  'vpath %.gir $(builddir):$(srcdir)' since
   the builddir is always searched before vpath directories.

 * Replace inexplicable usage of $(builddir)/$(@F) and $(@F) with
   plain-old $@
Comment 1 Owen Taylor 2009-08-15 13:18:06 UTC
Created attachment 140840 [details] [review]
autoconf-2.64 compat: Don't use $(builddir)
Comment 2 Colin Walters 2009-08-17 04:10:03 UTC

*** This bug has been marked as a duplicate of bug 591901 ***
Comment 3 Owen Taylor 2009-08-17 15:08:39 UTC
This was gir-repository, not gobject-introspection
Comment 4 Owen Taylor 2009-08-17 17:03:19 UTC
Got earlier approval from Colin to push, will assume that it's OK. Definitely passes distcheck, which is the main stress test.

Pushed.
Comment 5 André Klapper 2015-02-07 16:57:44 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]