After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591874 - Right sidebar packing does not respect child size requests
Right sidebar packing does not respect child size requests
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-15 05:17 UTC by John Iacona
Modified: 2009-08-18 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix for minimum width problems in right sidebar (806 bytes, patch)
2009-08-15 05:21 UTC, John Iacona
none Details | Review

Description John Iacona 2009-08-15 05:17:07 UTC
Please describe the problem:
The right sidebar area is packed using the "shrink=True" packing option. As a result, gtk does not respect the minimum size of widgets that have been added to the right sidebar. This causes strange things to happen such as gtk trying to allocate negative width items.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 John Iacona 2009-08-15 05:21:02 UTC
Created attachment 140826 [details] [review]
fix for minimum width problems in right sidebar

sets the shrink packing option to false which seems to make gtk respect size requests of children. This allows a minimum width to be set.
Comment 2 Jonathan Matthew 2009-08-16 05:06:00 UTC
This seems to make it impossible to shrink the right sidebar by moving the separator, which sort of sucks.
Comment 3 John Iacona 2009-08-17 00:27:56 UTC
(In reply to comment #2)
> This seems to make it impossible to shrink the right sidebar by moving the
> separator, which sort of sucks.

I do not have access to my dev computer for a few days so I can't test this. When I was testing, I put a container in the sidebar which I had used set_size_request on. This seemed to give me the behaviour I was looking for which was setting a minimum size for the width of the sidebar. However, I did not try when no size_request was explicitly set.
Comment 4 Jonathan Matthew 2009-08-17 02:12:17 UTC
I was just using the context pane plugin, but I haven't pulled from your repo for a while now, so maybe there's some bad interaction there that you've already fixed.  I'll try again later and if it works OK, I'll commit the patch.
Comment 5 Jonathan Matthew 2009-08-18 12:08:02 UTC
OK, it works properly with the current context pane plugin, so I've committed it.