GNOME Bugzilla – Bug 591658
update-notifier crashed with SIGSEGV in gdu_pool_get_devices()
Last modified: 2009-08-29 12:21:27 UTC
The bug has been opened on https://bugs.launchpad.net/bugs/403192 "#0 gdu_pool_get_devices (pool=0x0) at gdu-pool.c:1345 list = (GList *) 0x1 ret = (GList *) 0x0 l = <value optimized out> __PRETTY_FUNCTION__ = "gdu_pool_get_devices"
+ Trace 216908
There is several duplicates on launchpad but no clear way to trigger the crash
Hi, This crash is actually from update-notifier, but there is the same issue in gdu-notification. Attached is a proposed patch to avoid the crash in that case. Thanks, James
Created attachment 140652 [details] [review] Patch to handle NULL from gdu_pool_new
Created attachment 140654 [details] [review] Patch to handle NULL from gdu_pool_new
I've set the importance to critical because It's a crash
Uh, something with your system is misconfigured if gdu_pool_new() returns NULL... do you not have DeviceKit-disks correctly installed?
I'm not sure what went wrong. devkit-disks behaves fine now. I've only seen the issue once so far, at login, so it could possibly be a race condition. I'll watch out for further issues. Thanks, James
Ok, the issue seems to be that http://cgit.freedesktop.org/DeviceKit/DeviceKit-disks/tree/data/org.freedesktop.DeviceKit.Disks.conf.in doesn't allow org.freedesktop.DBus.Properties to be called on that interface, which is required for g-d-u. (gdu-notification-daemon:5490): libgdu-WARNING **: Couldn't call GetAll() to get properties for /: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken. (gdu-notification-daemon:5490): libgdu-WARNING **: Couldn't get daemon properties Thanks, James
For the record, James did a patch: http://bazaar.launchpad.net/~james-w/ubuntu/karmic/devicekit-disks/fix-403192/revision/14
https://bugs.freedesktop.org/show_bug.cgi?id=23579 filed for the change to DeviceKit-disks. Thanks, James
Thanks, James. The original reporter confirmed that the devkit d-bus ACL update fixes this problem. So based on David's assessment above I close this.