After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591610 - asfmux: messing up with sinkpads
asfmux: messing up with sinkpads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal blocker
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-12 21:14 UTC by Thiago Sousa Santos
Modified: 2009-08-12 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the problem (1.83 KB, patch)
2009-08-12 21:37 UTC, Thiago Sousa Santos 		accepted-commit_now Details | Review

Description Thiago Sousa Santos 2009-08-12 21:14:11 UTC 
asfmux might mess up sinkpads when it writes indexes because it sorts the GstCollectData list in GstCollectPads (because the spec wants video pads in stream number order). While developing it I assumed the g_slist_reverse would create a new list, but it doesn't.

As a result, some of the GstCollectData might be lost and the muxer will use only the remaining ones to compute media duration and other fields.

The solution is to copy the list and then reverse it.
Comment 1 Thiago Sousa Santos 2009-08-12 21:37:42 UTC 
Created attachment 140592 [details] [review]
Fixes the problem

Proposed patch.
Comment 2 Tim-Philipp Müller 2009-08-12 22:01:25 UTC 
Makes sense, please commit.
Comment 3 Thiago Sousa Santos 2009-08-12 22:29:06 UTC 
Module: gst-plugins-bad
Branch: master
Commit: c83615fca957b2045087433fd5a2e13204253aa2
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=c83615fca957b2045087433fd5a2e13204253aa2

Author: Thiago Santos <thiagoss@embedded.ufcg.edu.br>
Date:   Wed Aug 12 18:33:22 2009 -0300

asfmux: Do not mess up GstCollectData list

asfmux was messing up with the GstCollectData list of its
GstCollectPads when sorting the list inplace. This patch makes
it copy the list before sorting it, leaving the GstCollectPads
list as is. Fixes #591610



Commited