GNOME Bugzilla – Bug 591591
Gloverlay makes it hard to manipulate the position of the image
Last modified: 2009-09-02 09:17:33 UTC
Adding features such as controlling the size and position of the image would ease it's use. Other information:
Created attachment 140570 [details] [review] patch of gloverlay
Yep it could be good enhancement and I planned to do it sooner or later. I'm having a hard time reviewing your patch since it doesn't apply to current tree and it's in a pretty uncommon format (I cannot even figure out which lines are added and which removed...). Could you update it to apply to the current git tree and provide it in a decent format (git format-patch would be the best, git diff and diff -u almost as good)? Thank you!
Created attachment 140681 [details] [review] Patch for the last version of gst-gloverlay
(In reply to comment #3) > Created an attachment (id=140681) [edit] > Patch for the last version of gst-gloverlay > I have added the new patch for gstgloverlay.
I tried to apply the patch in the following way: git apply 0001-Added-New-version-Gstgloverlay.patch gst/gl/0001-Added-New-version-Gstgloverlay.patch:34: trailing whitespace. "X position of overlay image in percents", gst/gl/0001-Added-New-version-Gstgloverlay.patch:41: trailing whitespace. "Y position of overlay image in percents", gst/gl/0001-Added-New-version-Gstgloverlay.patch:47: trailing whitespace. "Relative size of iverlay image, in percents", gst/gl/0001-Added-New-version-Gstgloverlay.patch:57: trailing whitespace. gst/gl/0001-Added-New-version-Gstgloverlay.patch:73: trailing whitespace. warning: 5 lines add whitespace errors. The git diff print no diff I also tried: git apply --whitespace=nowarn 0001-Added-New-version-Gstgloverlay.patch any idea ?
Created attachment 142250 [details] [review] Patch for the last version of gst-gloverlay functionnal Now the patch should work with the last version of gst-plugins-gl
Hi, no yet :P git apply -v gstgloverlay.patch Checking patch gst/gl/gstgloverlay.c... error: while searching for: gchar *location; gboolean pbuf_has_changed; guchar *pixbuf; gint width, height; GLuint pbuftexture; error: patch failed: gst/gl/gstgloverlay.c:54 error: gst/gl/gstgloverlay.c: patch does not apply At this time there is no "gchar *location;" in http://cgit.freedesktop.org/gstreamer/gst-plugins-gl/tree/gst/gl/gstgloverlay.c because it has been moved to gstgloverlay.h added since: http://cgit.freedesktop.org/gstreamer/gst-plugins-gl/commit/?id=d8826559d638cbad1ad5984a988823ec120061a7
Created attachment 142302 [details] [review] Patch for gst-plgins-gl 0.10.1.1 Now the patch should work with the version 0.10.1.1 of gst-plugins-gl. The patch must be in source of the plugin.
commit 8cf6ca13fa3a458afb300a2eeab21dc09b1cf07d Author: Anthony Violo <anthony.violo@ubicast.eu> Date: Wed Sep 2 10:06:36 2009 +0200 gloverlay: can control image size and position Fix bug #591591
Sorry for neglecting this patch review. It's summer, you know, beach, sun, no laptop... :P Thanks Julien for taking care of this, and thank you again Anthony for the patches.