After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591476 - Possible leak in rtpbin
Possible leak in rtpbin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-11 18:48 UTC by Olivier Crête
Modified: 2009-08-14 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpbin: Fix reference leak (1.13 KB, patch)
2009-08-11 18:49 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2009-08-11 18:48:44 UTC
Attaching a patch for a reference leak in rtpbin
Comment 1 Olivier Crête 2009-08-11 18:49:12 UTC
Created attachment 140471 [details] [review]
rtpbin: Fix reference leak
Comment 2 Tim-Philipp Müller 2009-08-12 22:40:30 UTC
Maybe it's just me, but the use of that name_found variable is just very confusing.

Anyway, patch looks correct and I have a unit test to go with it as well, so I'd say let's put it in.
Comment 3 Tim-Philipp Müller 2009-08-14 12:48:29 UTC
commit 80e43452a1e9ffd11d105d31d75aa72217352268
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Aug 14 13:45:08 2009 +0100

    checks: add test for leak to rtpbin unit test
    
    See #591476.

commit 7f569ca9c8c51ab4750c20771f37e0beeca3b050
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Tue Aug 11 14:47:12 2009 -0400

    rtpbin: Fix reference leak
    
    Fixes #591476.