After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591353 - update man page
update man page
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-10 17:48 UTC by Jonh Wendell
Modified: 2009-08-12 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update manpage for recent changes (3.36 KB, patch)
2009-08-11 15:21 UTC, Emilio Pozuelo Monfort
rejected Details | Review
update manpage (4.03 KB, patch)
2009-08-12 12:04 UTC, Emilio Pozuelo Monfort
committed Details | Review

Description Jonh Wendell 2009-08-10 17:48:19 UTC
Changes in command line:

1) -f file becomes -F file (changed the flag to uppercase)

2) added --fulscreen/-f option: Open vinagre in fullscreen mode

3) It's allowed to supply only the port part, if hostname is missing then "localhost" is assumed:
  "vinagre :0" = "vinagre ::5900" = "vinagre localhost:0"
Comment 1 Jonh Wendell 2009-08-10 17:51:51 UTC
Emilio, could you fix this little bug? Thanks.
Comment 2 Emilio Pozuelo Monfort 2009-08-11 15:21:54 UTC
Created attachment 140452 [details] [review]
Update manpage for recent changes

Hi Jonh,

How does this patch look like?
Comment 3 Jonh Wendell 2009-08-11 16:22:09 UTC
Hi, Emilio, some points:

- Currently vinagre is not just a VNC client. Perhaps you should mention that in the name: "vinagre - a remote desktop viewer for the GNOME Desktop" and in the description. You could mention that vinagre *currently* only supports VNC and SSH, but it's extensible through plugins.

- In the options, there is a new group: --help-vnc , which gives options specific to the vnc protocol (--gtk-vnc-debug was moved to there)

- Operands: Maybe it's better to mention something like that:
  [server][::port|:display]
  So that people know that they must use one of the syntax, not both.

- Example 7 could be something like ::5900 or :0, once port 25 is well known to be smtp.

Thanks!
Comment 4 Emilio Pozuelo Monfort 2009-08-12 12:04:50 UTC
Created attachment 140546 [details] [review]
update manpage

I've tried to address your comments now. How does it look?

If you only see syntax issues, feel free to correct them and commit it directly. I'm not a native speaker :)
Comment 5 Jonh Wendell 2009-08-12 12:57:31 UTC
Perfect, thanks!