After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591124 - Reposition windows when scaling workspaces
Reposition windows when scaling workspaces
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-08 05:04 UTC by Owen Taylor
Modified: 2009-08-10 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reposition windows when scaling workspaces (2.55 KB, patch)
2009-08-08 05:04 UTC, Owen Taylor
reviewed Details | Review

Description Owen Taylor 2009-08-08 05:04:39 UTC
If you have some small windows, it's very obvious that when you
go from 1 workspace to 2 workspaces:

 - The windows are left too small

And when you go from 2 workspaces to 1 workspace:

 - The windows are left too big and will be scaled up beyond
   their original size

This patch fixes it by exporting positionWindows from Workspace
and calling it at the appropriate time. Alternative would be
to have workspace.setScale() rather than have have Workspaces
set workspace.scale directly - then the Workspace object could
call _positionWindows as appropriate.

That's maybe a little cleaner but some care would have to be
taken to not have the code start multiple animations.
Comment 1 Owen Taylor 2009-08-08 05:04:42 UTC
Created attachment 140180 [details] [review]
Reposition windows when scaling workspaces

The scale of windows within a workspace is determined by the
scale of the workspace since we never scale a window bigger
than the original size of the window. So when we rescale
workspaces we have to rerun Workspace.positionWindows().
Comment 2 Dan Winship 2009-08-10 13:59:30 UTC
sure
Comment 3 Owen Taylor 2009-08-10 14:11:05 UTC
Pushed. Thanks for the review.