After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591122 - Fix updating of workspace frame actor
Fix updating of workspace frame actor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-08 04:55 UTC by Owen Taylor
Modified: 2009-08-10 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix updating of workspace frame actor (2.16 KB, patch)
2009-08-08 04:55 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2009-08-08 04:55:00 UTC 
This fixes a problem where on adding or removing workspaces the
frame is left in the wrong position. It's a lot more visible
when running in Xephyr without hardware acceleration, I think
because there are very few steps to animations.
Comment 1 Owen Taylor 2009-08-08 04:55:04 UTC 
Created attachment 140178 [details] [review]
Fix updating of workspace frame actor

Both the position and size of the frame actor depend on the scale
of the workspace, so update them both when the scale changes.

On the other hand, the the frame actor doesn't need to be
repositioned when the workspace moves (since it is relative to the
workspace). We do base the frame  position of the desktop actor, but
that will presumably stay fixed (at 0,0) in most all cases.
Comment 2 Dan Winship 2009-08-10 13:53:36 UTC 
i can't figure out how to reproduce the drawing glitch you're talking about, but i agree with the logic
Comment 3 Owen Taylor 2009-08-10 13:58:07 UTC 
I was seeing it just by running gnome-shell in Xephyr and adding and removing workspaces. Frequently when I went from 2 workspaces to 1 workspaces, the frame would be left considerably off-center.

Pushed, thanks for the review.