After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590998 - Turn on -Werror and -Wmissing-prototypes
Turn on -Werror and -Wmissing-prototypes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-06 20:45 UTC by Owen Taylor
Modified: 2009-08-06 21:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Turn on -Werror and -Wmissing-prototypes (1.89 KB, patch)
2009-08-06 20:46 UTC, Owen Taylor 		accepted-commit_now Details | Review
Fix compiler warnings (6.84 KB, patch)
2009-08-06 20:46 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2009-08-06 20:45:13 UTC 
Here are some patches that add -Werror -Wmissing-prototypes and fix
the problems that reveals.
Comment 1 Owen Taylor 2009-08-06 20:46:56 UTC 
Created attachment 140061 [details] [review]
Turn on -Werror and -Wmissing-prototypes

When compiling with GCC turn on -Wmissing-prototypes, and by default
turn on -Werror as well.

As with most gnome modules:

 --enable-compile-warnings=minimum/maximum

Can be used to disable -Werror (they are the same)
Comment 2 Owen Taylor 2009-08-06 20:46:59 UTC 
Created attachment 140062 [details] [review]
Fix compiler warnings

src/shell-global.c src/shell-process.c: Remove dead code
src/shell-texture-cache.c src/shell-status-menu.c: Remove
  <foo>_new() functions that weren't in the header file and
  not used anyways:
src/shell-texture-cache.[ch]: Fix a prototype that used ()
  when (void) was intended.
Comment 3 Colin Walters 2009-08-06 21:31:22 UTC 
looks good
Comment 4 Owen Taylor 2009-08-06 21:44:55 UTC 
Both pushed