GNOME Bugzilla – Bug 590653
menu don't show icons for objects if menus_have_icons=false
Last modified: 2009-10-05 13:32:47 UTC
Even though this isn't part of the HIG yet [1] we want objects such as documents, bookmarks, applications and devices to always show icons (the HIG currently only mentions bookmarks), regardless of menus_have_icons is set to true or false. This would mean that Tomboy would make use of the gtk-image-menu-item-set-always-show-image [2] for all items below Search All Notes (but not Search all notes, since that's a action). This is especially important since GNOME recently changed menus_have_icons to false by default [3]. 1. http://bugzilla.gnome.org/show_bug.cgi?id=588668 2. http://library.gnome.org/devel/gtk/2.17/GtkImageMenuItem.html#gtk-image-menu-item-set-always-show-image 3. http://bugzilla.gnome.org/show_bug.cgi?id=557469
We're talking about the Tomboy note menu here, right? "All items below Search All Notes" is relative to panel positioning. Based on the "documents, bookmarks, applications, and devices" rule, I assume you mean that menu items that represent notes should always show the image. But "Create New Note", "Notebooks", and "Search All Notes" items should just go with the menus_have_icons setting. Is this correct?
Correct, those are kind of documents.
Thanks, Andreas. This API is only available in GTK+ 2.16, so we'll need to add some stuff to configure for conditionally including support for it, as I want Tomboy buildable on GTK+ 2.14. We can add the API in our GtkBeans area.
Created attachment 143561 [details] [review] Patch that fixes this Here's a patch that fixes this. Unfortunately I forgot about this bug until today. If anyone thinks I should request a break of code freeze to apply this patch, I will do so. But I don't think it's that vital, and I plan to release a 1.0.1 long enough before GNOME 2.28.1 that it will be the release shipped by most distros.
Comment on attachment 143561 [details] [review] Patch that fixes this Pushed to master and gnome-2-28 branch. I'll probably make a 1.0.1 a little earlier than GNOME 2.28.1 to encourage distros to pick up this fix (and whatever else we may find).
It looks like you forgot to add and commit Tomboy/gtk-sharp-beans/ImageMenuItem.cs, so Tomboy fails to build: Tray.cs(36,30): error CS1061: Type `Tomboy.NoteMenuItem' does not contain a definition for `SetAlwaysShowImage' and no extension method `SetAlwaysShowImage' of type `Tomboy.NoteMenuItem' could be found (are you missing a using directive or an assembly reference?)
Oh, thanks, I forgot to push this file on the branch. Doing it now.