GNOME Bugzilla – Bug 590559
[HIG] Massive infringements in Sound Preferences dialog
Last modified: 2009-08-12 22:36:11 UTC
There are several HIG infringements in Sound Preferences capplet. I'll list here some of more visibile, but I suggest a full review of each widged :/ * bad label bapitalization - some labels should use sentence capitalization instaed header: "Output Volume:", "Alert Volume:", "Sound Theme:", "Input Volume:" * missing access key - the key used to activate a widget or focus the linked one: the ones listed before, plus "Mute", "Enable window and button sounds", "Choose an alert sound:", "Choose a device to configure:", "Choose a device for sound input" (missing : here), "Choose a device fro sound output" (missing : here) * bad spacing/alignment - the close button on bottom right corner should be aligned to notebook right border (also check the spacing between the top edge of the same button and bottom edge of notebook); the "Sound Theme:" label should be aligned on left, same for "Choose an alert sound:" below; this one should have 6 pixels between itself and the treeview; maybe other, such as the "Output Volume:" that should be left aligned to notebook left border
Got patches?
No, and I don't think I'll have the ability to do it in time for UI freeze :(
I forgot the "Profile:" label. It needs access key.
(In reply to comment #0) > There are several HIG infringements in Sound Preferences capplet. I'll list > here some of more visibile, but I suggest a full review of each widged :/ > > * bad label bapitalization - some labels should use sentence capitalization > instaed header: "Output Volume:", "Alert Volume:", "Sound Theme:", "Input > Volume:" Fixed. > * missing access key - the key used to activate a widget or focus the linked > one: the ones listed before, Done. > plus "Mute", Can't, multiple widgets use the same button. > "Enable window and button sounds", Done. > "Choose an alert sound:" Done. > , "Choose a device to configure:" Done. >, "Choose a device for > sound input" (missing : here), "Choose a device fro sound output" (missing : > here) Done. > * bad spacing/alignment - the close button on bottom right corner should be > aligned to notebook right border (also check the spacing between the top edge > of the same button and bottom edge of notebook); I can't seem to be able to do that whilst keeping the whole window be a dialogue. Could you give a try to fixing it, or file a separate bug? (stuff like "action-area-border" and "content-area-border" from the style properties of the dialog and the theme applying weird values is most likely to blame) > the "Sound Theme:" label > should be aligned on left, same for "Choose an alert sound:" below; this one > should have 6 pixels between itself and the treeview; Fixed, and made it bold like the other ones. > maybe other, such as the > "Output Volume:" that should be left aligned to notebook left border Those are aligned with each other (eg. all the volume bars are aligned with the one at the top of the dialogue).
Created attachment 140558 [details] [review] Fix mnemonics and labels
Created attachment 140559 [details] [review] And updated fix Was missing the profiles and connectors mnemonics
(In reply to comment #6) > Created an attachment (id=140559) [edit] > And updated fix > > Was missing the profiles and connectors mnemonics > - dialog->priv->input_port_combo = gvc_combo_box_new (_("Connector:")); + dialog->priv->input_port_combo = gvc_combo_box_new (_("_Connector:")); There is yet _Close using _C
Could you please file a separate bug for the Close button alignment? I used 'n' as the mnemonic to the connector labels. commit 447d6c94868f7162483e80328365997ae07d1657 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Aug 12 23:24:35 2009 +0100 Bug 590559 – [HIG] Massive infringements in Sound Preferences dialog - Add mnemonics, and mnemonic widgets - Fix spacing and heading for the sound theme