GNOME Bugzilla – Bug 590470
[typefinding] certain flac-in-ogg files not detected any longer
Last modified: 2009-08-01 18:09:51 UTC
Playback of certain flac-in-ogg files is broken because oggdemux doesn't recognise them properly any longer. These files aren't framed according to the ogg mapping spec, but basically just contain the flac bytestream in ogg packets. These files then have a 4-byte packet as first ogg packet, and we need to detect the right type from these 4 bytes. The typefinder, however, requires at least 6 bytes and hence fails to detect the stream properly. Sample file: samples-mplayer/flac.samples/Yesterday.ogg
Created attachment 139695 [details] [review] fix flac detection in case of 4-byte ogg ID packet
Thanks, committed: commit e199d7e1cd25eee6d7d3314f83bdda461eb1b509 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sat Aug 1 17:26:23 2009 +0100 typefinding: fix detection of fLaC id packet in broken flac-in-ogg There are flac-in-ogg files without the usual flac packet framing and these files just have a 4-byte fLaC ID packet as first packet. We need to recognise the type just from these four bytes if we want oggdemux to recognise these streams correctly.